Firestore TransactionOptions added, to specify maxAttempts

[dconeybe]

This is a port of firebase/firebase-cpp-sdk#966, firebase/firebase-ios-sdk#9838 and firebase/firebase-android-sdk#3664, which adds the new TransactionOptions class to Firestore, which can be used to specify the maximum number of attempts to run a transaction before giving up. Previously, this maximum was hardcoded to 5.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 75497f2
Last updated: Wed Jul 6 17:08 PDT 2022
View integration test log & download artifacts

Failures	Configs
analytics	[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
firestore	[BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): Android] [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): ios_target] [TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): ios_target]
functions	[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
installations	[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
messaging	[TEST] [ERROR] [2019] [macos] [2/5 Platform(s): iOS Android] [All 2 FTL Devices] [TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
storage	[TEST] [FAILURE] [2019] [macos] [4/5 Platform(s): ubuntu iOS macos windows] [1/3 Test Device(s): simulator_target]

[dconeybe]

https://github.com/firebase/firebase-unity-sdk/actions/runs/2584731985 triggered to build and run the full suite of integration tests.

Update: Build failed: ld: error: cannot find -lfirebase_auth. I think I need to include auth when testing firestore due to firestore's dependency on auth. I'll try again.

[dconeybe]

https://github.com/firebase/firebase-unity-sdk/actions/runs/2584931823 triggered to build and run the full suite of integration tests, this time including auth with firestore to hopefully avoid the ld: error: cannot find -lfirebase_auth error.

Update: The build was successful; the integration tests have been started: https://github.com/firebase/firebase-unity-sdk/actions/runs/2585337183

Update: I couldn't get the build-2019-macos-latest-Android action to pass. It was apparently due to an Android NDK compatibility issue.

[dconeybe]

https://github.com/firebase/firebase-unity-sdk/actions/runs/2592067531 triggered to build and run the full suite of integration tests, this time I've temporarily cherry-picked an Android NDK fix (5a934e1) to hopefully fix the build issues in the build-2019-macos-latest-Android action when running the integration tests.

(note that the last attempt at this run hung on Install Unity in macOS for 3+ hours: https://github.com/firebase/firebase-unity-sdk/actions/runs/2591114395)

Update: The build was successful; the integration tests have been started: https://github.com/firebase/firebase-unity-sdk/actions/runs/2592455470

[dconeybe]

https://github.com/firebase/firebase-unity-sdk/actions/runs/2594580720 started after merging in the Android fix from the main branch.

Integration Tests: https://github.com/firebase/firebase-unity-sdk/actions/runs/2594914112 (failed on Android)

[jonsimantov]

Hmm, the Android build is still failing. @sunmou99 any idea if this is related?

[sunmou99]

Hmm, the Android build is still failing. @sunmou99 any idea if this is related?

The unity installation tool seems unstable. I will add retry logic into the tool itself.

[dconeybe]

Build workflow: https://github.com/firebase/firebase-unity-sdk/actions/runs/2624659988

Integration tests: https://github.com/firebase/firebase-unity-sdk/actions/runs/2625079199