- Notifications
You must be signed in to change notification settings - Fork 122
Firestore TransactionOptions added, to specify maxAttempts#966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… PR that adds Snappy support has been merged there
…f the firebase-ios-sdk
…9838, which adds TransactionOptions
…and assignment operator.
…PLE_HARD_ASSERT when given an invalid max_attempts
…tic python_setup.cmake bug
…, which fixes a problematic usage of designated initialization
…operties and settings.gradle
❌ Integration test FAILEDRequested by @dconeybe on commit 252ab6c
Add flaky tests to go/fpl-cpp-flake-tracker |
Everything looks good on desktop and iOS (https://github.com/firebase/firebase-cpp-sdk/actions/runs/2553982778). Need to test Android once this repository's dependency on |
Android dependencies have now been upgraded: #1007 I've kicked off integration tests to test all platforms, including Android: https://github.com/firebase/firebase-cpp-sdk/runs/7051060951 I've also kicked off the packaging workflow to make sure it won't break anything: https://github.com/firebase/firebase-cpp-sdk/actions/runs/2559321031 |
This is a port of firebase/firebase-ios-sdk#9838 and firebase/firebase-android-sdk#3664, which adds the new
TransactionOptions
class to Firestore, which can be used to specify the maximum number of attempts to run a transaction before giving up. Previously, this maximum was hardcoded to 5.