The Wayback Machine - https://web.archive.org/web/20210525011504/https://github.com/qbittorrent/qBittorrent/pull/6484
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change qbittorrent logo. Issue #6467. #6484

Merged
merged 5 commits into from Nov 19, 2017

Conversation

@sledgehammer999
Copy link
Member

@sledgehammer999sledgehammer999 commented Mar 7, 2017

All pngs where created via GIMP. The .ico file was created by taking the relevant pngs and using icotool program. The .icns file was created by taking the relevant pngs and using png2icns program.
I wasn't able to find a program for the OS/2 .ico format (different from the Windows .ico) until I started commiting and compiling. But after that I found 2 promising programs Deark and Image Alchemy. I will try them later.

Caveats:

  1. src/icons/skin/splash.png has the old log embedded
  2. src/qbittorrent_file.ico wasn't recreated. I think I can do it if use the new logo plus src/icons/qbt-theme/text-plain.png from the old theme. Same goes for dist/mac/qBitTorrentDocument.icns

Pics:
file_icon
program

Notice how crappy the icon looks as an window-icon and as tray-icon? I think this is actually a regression of qt with 5.7.0 (or 5.7.1 don't remember). Can you confirm that it looks crap on yours too?

@sledgehammer999sledgehammer999force-pushed the sledgehammer999:new_logo branch from 5e88f18 to 91704eeMar 7, 2017
@sledgehammer999sledgehammer999 changed the title Change qbittorrent log. Issue #6467.Change qbittorrent logo. Issue #6467.Mar 7, 2017
@sledgehammer999sledgehammer999 mentioned this pull request Mar 7, 2017
@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Mar 7, 2017

@LordNyriox Just so you know, I inspected the old icns and ico files to see what sizes they used. And then I used same sizes for the new icon. I have no problem using files created by you.
PS: Does that mean that you will recreate the various pngs too? If yes, can you do the same for the 2nd logo posted here too?

@bugmenot2
Copy link

@bugmenot2bugmenot2 commented Mar 8, 2017

Hi @LordNyriox, my design lacks vectors completely, so can't be exported to SVG... 😊

@bugmenot2
Copy link

@bugmenot2bugmenot2 commented Mar 9, 2017

Sorry to bug you 😁

Please stop deleting your comments, it's annoying!

I started with 2 layers (one for the text and another for the orb), then rendered both to be able to use image-oriented tools and effects (I couldn't do what I wanted with vectors).

If you really need a SVG for the job you can embed a picture like this:

<?xmlversion="1.0"standalone="no"?> <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 20010904//EN" "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd"> <svgid="test"width="512px"height="512px"xmlns="http://www.w3.org/2000/svg"xmlns:xlink="http://www.w3.org/1999/xlink"> <imagex="0px"y="0px"width="512px"height="512px"xlink:href="whatever.png"></image> </svg>
@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Mar 9, 2017

IMO, better focus on the svg one. Sorry @bugmenot2. Thanks for the contribution though.

@bugmenot2
Copy link

@bugmenot2bugmenot2 commented Mar 9, 2017

Excuse me @sledgehammer999, 1024 x 1024 for an icon isn't enough?

@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Mar 9, 2017

Excuse me @sledgehammer999, 1024 x 1024 for an icon isn't enough?

It is enough, but if @LordNyriox prefers to work with svg, I just told him to let go of trying to get an svg version of your logo.

Generally we're trying to migrate to svg so we can load them natively in Qt without relying on generated pngs. Presumably this will help with scaling and highDPI screens.

@bugmenot2
Copy link

@bugmenot2bugmenot2 commented Mar 9, 2017

I'm fine working with @LordNyriox to get this job done, I also have the necessary knowledge/toolset to build icons and PNGs for the program 😄

@surfernsk
Copy link
Contributor

@surfernsksurfernsk commented Mar 10, 2017

@bugmenot2 Why in svg the link to png?
<image x="0px" y="0px" width="1024px" height="1024px" xlink:href="qBittorrent-1024.png">

@surfernsk
Copy link
Contributor

@surfernsksurfernsk commented Mar 10, 2017

Dear @bugmenot2 , thank you for the work you have done.

PS.
You were offended by my question?

@bugmenot2
Copy link

@bugmenot2bugmenot2 commented Mar 10, 2017

Nah, your question was fine, voting down my comment was a little rough though 😄
It's all good 👍

@Chocobo1
Copy link
Member

@Chocobo1Chocobo1 commented Mar 10, 2017

First, I do like @bugmenot2 icon.
But embedding png into svg, doesn't that still be raster graphic? If so, then just use png format will be better (because compression).
The point of svg format is to carry vector graphic. Or I'm missing something?

@surfernsk
Copy link
Contributor

@surfernsksurfernsk commented Mar 10, 2017

@bugmenot2 Alas, the last option is not vector. You were asked to provide a vector version of the logo, if possible.

something like that (based on bugmenot2 qBittorrent-1024.png) - qBittorrent-vector(draft).zip (My skills in owning vector graphics are very small, the quality may be insufficient)

qbittorrent-vector draft svg-96
qbittorrent-vector draft svg-128

@atfzl
Copy link

@atfzlatfzl commented Mar 10, 2017

Hi @LordNyriox,

The png that you have exported have a lot of aliasing.
If you zoom in, you can see the edges in the curves.
Here is your uploaded png for 1024 x 1024:
qbittorrent-new-1024

Here is the anti-aliased version:
qbittorrent new 1024 anti aliased

Also the color is not correct for the mac version (.icns file)

qbittorrent-new.icns.zip

@atfzl
Copy link

@atfzlatfzl commented Mar 10, 2017

I'll recreate @bugmenot2's version of icon tomorrow in proper vector format in Sketch app.
I'll export both icons to all the required sizes (16, 22, 24, 32, 36, 48, 64, 72, 96, 128, 192, 256, 512, 1024) png, svg, ico and icns.

@bugmenot2
Copy link

@bugmenot2bugmenot2 commented Mar 11, 2017

I have an entire workflow for generating Windows .ico files, and I know how to generate complete mac .icns files.

If I create a set of Windows and Mac program icons, would you use them (they will have a fairly large filesize, but they will be top quality).

On my Windows machine, all I did was use GIMP's built in SVG importer and ICO/PNG exporters to generate the ICO/PNG files.

I did not perform any kind of anti-aliasing task, mostly because I'm don't have the right tools.

...

Epic Triple Facepalm

@atfzl
Copy link

@atfzlatfzl commented Mar 11, 2017

Both logo with original source sketch file and exported resources(only .ico is not there):

qbittorrent-new.zip

@surfernsk
Copy link
Contributor

@surfernsksurfernsk commented Mar 11, 2017

@LordNyriox, @atfzl, @sledgehammer999 that about qbit.zip1024px

change: add text shadow

@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Mar 13, 2017

I like @atfzl new svg too. @surfernsk your mod looks good too but nowadays my preference tends to the "flat design" side. I could be wrong. I have to look at the smaller icons too. There they might look much better.

Thx for the contributions guys, I'll try to look at them this weekend.

@mantas3
mantas3 approved these changes May 3, 2017
@Inamaru
Copy link

@InamaruInamaru commented May 27, 2017

@sledgehammer999 I was wondering if I still got the chance to make some logo design before this is approved.

@surfernsk
Copy link
Contributor

@surfernsksurfernsk commented Oct 3, 2017

@sledgehammer999 Logo with Open Sans (optimized, 1004px) download

qbittorrent_open_sans svgqbittorrent-light_open_sans svg

@surfernsk
Copy link
Contributor

@surfernsksurfernsk commented Oct 3, 2017

@sledgehammer999 What do you think about
g114-7-7
click to enlarge
download

P.S.
I was a little transformed font Open Sans, so license free
update: added more option

@sledgehammer999sledgehammer999force-pushed the sledgehammer999:new_logo branch from 65cc3d7 to e37f31fOct 6, 2017
@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Oct 6, 2017

@surfernsk I proceeded on my own because this back-n-forth action takes time.

I removed the padding around the circle as mentioned earlier. Then I used the same ratio to increase the font size. I used Inkscape to re-center vertically+horizontally the bigger text. And then I converted the letters to paths. (I used the open sans font).

I have pushed new commits using the new svg with open sans font. I think this is my final decision. I have included both svgs, one that uses the font and one that uses path for the letters. For easier modification down the road. Minor tweaks can be performed afterwards with new PRs.
So, unless there is a good argument against it I am going to merge this at some point in the next days.

Here are 2 screenshots on how it looks on Windows 7:
untitled1
untitled

@LordNyriox
LordNyriox approved these changes Oct 7, 2017
@sledgehammer999sledgehammer999 mentioned this pull request Oct 9, 2017
@sledgehammer999sledgehammer999force-pushed the sledgehammer999:new_logo branch 2 times, most recently from bf85198 to 1135a71Oct 12, 2017
@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Oct 12, 2017

  1. Commit with splash screen modification has been pushed (yeah I know, it's not very creative)
  2. Commit changing the fileicon has been pushed too:
    fileicon256

I think I'll find time this weekend to make macOS icns files too. Then this will be merged and v4.0.0 will be released.

@bug-me-not did you see my reply on your PM?

@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Oct 15, 2017

@bug-me-not One final PM in the forum by me.

@sledgehammer999sledgehammer999force-pushed the sledgehammer999:new_logo branch from 1135a71 to 0873483Oct 24, 2017
@bug-me-not
bug-me-not approved these changes Oct 24, 2017
@sledgehammer999
@sledgehammer999
@sledgehammer999
@sledgehammer999
@sledgehammer999
@sledgehammer999sledgehammer999force-pushed the sledgehammer999:new_logo branch from 0873483 to a89c1a8Oct 30, 2017
@sledgehammer999sledgehammer999 added this to the 4.0.0 milestone Nov 19, 2017
@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Nov 19, 2017

Merging this since I am beginning the release of v4.0.0.

Thx to all contributors, commentators and critics.

@sledgehammer999sledgehammer999 merged commit 9db1f3b into qbittorrent:masterNov 19, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sledgehammer999sledgehammer999 deleted the sledgehammer999:new_logo branch Nov 19, 2017
@ghost
Copy link

@ghostghost commented Nov 20, 2017

Hey guys, the new icon is not production ready on 4.0.0. It's aliased on every small size. Definitely needs work.

@sledgehammer999
Copy link
Member Author

@sledgehammer999sledgehammer999 commented Nov 20, 2017

Hey guys, the new icon is not production ready on 4.0.0. It's aliased on every small size. Definitely needs work.

See #7725 (comment)

@@ -251,7 +251,6 @@
<file>icons/flags/zw.svg</file>
<file>icons/L.gif</file>
<file>icons/loading.png</file>
<file>icons/qbittorrent.png</file>

This comment has been minimized.

@Chocobo1

Chocobo1Nov 20, 2017
Member

The webUI login screen is missing the qbt logo, I guess is due to this line.

@glassez
Since you have #7610, maybe you can fix this in your PR, or let me know to open a PR for this.

@glassez
Copy link
Member

@glassezglassez commented Nov 20, 2017

Don't wait until #7610. Just return it back.

@Chocobo1
Copy link
Member

@Chocobo1Chocobo1 commented Nov 20, 2017

Don't wait until #7610. Just return it back.

OK, see PR #7764.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
13 participants
@sledgehammer999@bugmenot2@surfernsk@Chocobo1@atfzl@Inamaru@maverick74@adxanim@Donnnno@bug-me-not@glassez@mantas3@LordNyriox
close