[6.2][Concurrency] Update task name APIs, move to modifying AEIC funcs#81132
+586 −1,362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…RCH and SUBDIR for builds products
…EIC funcs [Concurrency] Lower availability for task names + addTask WIP on changing the always emit into client funcs
…utor [Concurrency] Adjust tests for renamed initializer [Embedded][Concurrency] Workaround for Gyb+concurrency module+embedded Add Task+init gyb to embedded; Remove TaskGroup+Embedded.swift workaround [Concurrency] Undo build workaround
@swift-ci please test |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This adds "task name" parameter to all task creating functions.
This is done in a few ways, e.g. we can backdeploy this to 5.1 in APIs which do not accept the
TaskExecutorbut it they do we provide a version for 6.0+ etc. This was requested in the SE acceptable of this proposal Acceptance post SE-0469.This moves all these declarations to gyb since going through them one by one has become unmaintainable otherwise.
Scope/Impact: All task creation APIs now gain a new task name parameter.
Risk: Medium, changes existing APIs rather than adding "even more overloads" though this risk was discussed in the team and accepted. This has a potential to be source breaking it someone used Task.init and friends as function.
Testing: CI testing, source compatibility suite testing
Reviewed by:
Original PR:
Radar: