RedundantLoadElimination: support replacing a redundant copy_addr with a store#80912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
@swift-ci test |
eeckstein requested review from kubamracek, atrick, meg-gupta, nate-chandler and rauhul
…ith a `store` For example: ``` %0 = load %1 copy_addr %1 to %2 ``` -> ``` %0 = load %1 store %0 to %2 ``` This is important for MandatoryRedundantLoadElimination to be able to create statically initialized globals in the mandatory pipeline. For example: ``` public struct MyStruct { public static let r: Range<Int> = 1 ..< 3 } ``` gets a statically initialized global, even at Onone, with this improvement. rdar://149356742@swift-ci test |
Very cool, thanks, Erik! :) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
->
This is important for MandatoryRedundantLoadElimination to be able to create statically initialized globals in the mandatory pipeline. For example:
gets a statically initialized global, even at Onone, with this improvement.
rdar://149356742