Skip to content

Add get/setNAV5PositionAccuracy#224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2024

Conversation

cyclops1982
Copy link
Contributor

As asked/suggested/requested in #223.

This adds the option so set the pAcc parameter via UBX-CFG-NAV5.

The name of the method is somewhat strange. this is primarily because there is already a getPositionAccuracy.

Copy link
Collaborator

@PaulZCPaulZC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change setDynamicModel too. It needs the same |= change as per #223

Please add your new methods to keywords.txt

@cyclops1982
Copy link
ContributorAuthor

Thanks @PaulZC - i think i got everything now.

Copy link
Collaborator

@PaulZCPaulZC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @cyclops1982 - thanks!
One very small change to make... ;-)

@PaulZCPaulZC changed the base branch from main to release_candidateMay 30, 2024 07:39
@PaulZC
Copy link
Collaborator

Nice work Ruben - thanks!
Merging...

@PaulZCPaulZC merged commit 5582ed9 into sparkfun:release_candidateMay 30, 2024
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@cyclops1982@PaulZC
close