Skip to content

[MRG] Add iterable values support for dictvectorizer#17367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Aug 1, 2020
Merged

[MRG] Add iterable values support for dictvectorizer #17367

merged 68 commits into from
Aug 1, 2020

Conversation

cmarmo
Copy link
Contributor

@cmarmocmarmo commented May 27, 2020•
edited
Loading

Reference Issues/PRs

Closes#6045
Closes#6369
Resumes #8750

What does this implement/fix? Explain your changes.

Add iterable support for value types in dictvectorizer

@cmarmocmarmo changed the title [WIP] Add iterable values support for dictvectorizer[MRG] Add iterable values support for dictvectorizerMay 28, 2020
@cmarmo
Copy link
ContributorAuthor

cmarmo commented May 28, 2020•
edited
Loading

@jnothman, do you mind having a look when you have some time? I'm not sure your comment is addressed correctly. Thanks!

@cmarmo
Copy link
ContributorAuthor

Gentle ping for ... maybe @thomasjpfan ? Thanks!

jnothman
jnothman requested changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jnothmanjnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems we are not quite there, but we are very close!

@cmarmocmarmo requested a review from jnothmanJuly 28, 2020 11:28
@ogrisel
Copy link
Member

@jnothman it seems that all the comments of your last review have been addressed. Merge?

jnothman
jnothman reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@jnothmanjnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems these comments did not submit correctly

@cmarmocmarmo requested a review from jnothmanJuly 31, 2020 11:52
jnothman
jnothman approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@jnothmanjnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cmarmo. Sorry it went back and forth. Just realised the change log could say Feature instead of Enhancement. Either way, I guess.

@jnothmanjnothman merged commit 320b4c6 into scikit-learn:masterAug 1, 2020
@cmarmo
Copy link
ContributorAuthor

Thanks @jnothman and @ogrisel!

@cmarmocmarmo deleted the multi-value-dict-vec branch August 1, 2020 13:05
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@cmarmo@yupbank
@thomasjpfan@jnothman@jayzed82
FEA Add iterable values support for dictvectorizer (scikit-learn#17367)
ec6e863
 Co-authored-by: Peng Yu <peng.yu@shopify.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
@glemaitreglemaitre mentioned this pull request Apr 26, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:feature_extraction
5 participants
@cmarmo@jnothman@ogrisel@thomasjpfan@yupbank
close