[PGPRO-11557] Fix infinite loop with multiple ORDER BY in RUM scan#149
+5 −1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#66
Problem description:
When executing a query with ORDER BY col1, col2 using a RUM index, and the WHERE clause matches only a subset of the index, the query may enter an infinite loop in scanGetItemFast().
This occurs because entry->curItem is set via entry->curItem = collected.item;, but the corresponding entry->offset does not point to that item in entry->list. As a result, entryFindItem() may prematurely exit without correcting curItem, leading to repeated processing of the same item.
Fix:
Added an extra check in entryFindItem() that ensures:
If the last condition fails, the function continues scanning the list to realign curItem and offset.
This ensures scanGetItemFast() progresses correctly and prevents infinite looping.