Skip to content

ext/intl: Locale::* methods using param as path whenever relevant.#18365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

devnexen
Copy link
Member

No description provided.

@devnexendevnexen marked this pull request as ready for review April 20, 2025 13:44
@devnexendevnexen requested a review from nielsdosApril 22, 2025 06:37
Copy link
Member

@nielsdosnielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine so far, but what about zif_locale_set_default ?

@devnexendevnexenforce-pushed the intl_locale_usepath branch from 90f912a to fa964e8CompareApril 22, 2025 20:56
@devnexendevnexenforce-pushed the intl_locale_usepath branch from fa964e8 to 91c2310CompareApril 22, 2025 22:14
@devnexendevnexenforce-pushed the intl_locale_usepath branch from 91c2310 to ee64aa0CompareApril 22, 2025 22:38
@devnexendevnexen merged commit 5189450 into php:masterApr 22, 2025
7 of 9 checks passed
@devnexendevnexen deleted the intl_locale_usepath branch April 22, 2025 22:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
@devnexen@nielsdos
close