doc: get rid of redundant TODO tag in FuzzedDataProvider.h#137395
Conversation
'list.size()' is determined at runtime, so using static_assert on it as suggested by the TODO comment is not feasible and produces the following error when done: error: static assertion expression is not an integral constant expression Co-authored-by: Chand-ra <chandrapratap376@gmail.com>
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-compiler-rt-sanitizer Author: kevkevin (kevkevinpal) Changes'list.size()' is determined at runtime, so using static_assert on it as suggested by the TODO comment is not feasible and produces the following error when done: error: static assertion expression is not an integral constant expression initially referenced in bitcoin/bitcoin#32024 Full diff: https://github.com/llvm/llvm-project/pull/137395.diff 1 Files Affected:
diff --git a/compiler-rt/include/fuzzer/FuzzedDataProvider.h b/compiler-rt/include/fuzzer/FuzzedDataProvider.h index 11f2fbdb8c854..33ffa8bc00bfa 100644 --- a/compiler-rt/include/fuzzer/FuzzedDataProvider.h+++ b/compiler-rt/include/fuzzer/FuzzedDataProvider.h@@ -314,7 +314,6 @@ T FuzzedDataProvider::PickValueInArray(const std::array<T, size> &array) { template <typename T> T FuzzedDataProvider::PickValueInArray(std::initializer_list<const T> list) { - // TODO(Dor1s): switch to static_assert once C++14 is allowed. if (!list.size()) abort(); |
kevkevinpal changed the title 
@kevkevinpal Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
'list.size()' is determined at runtime, so using static_assert on it as suggested by the TODO comment is not feasible and produces the following error when done: error: static assertion expression is not an integral constant expression initially referenced in bitcoin/bitcoin#32024 Co-authored-by: Chand-ra <chandrapratap376@gmail.com>
'list.size()' is determined at runtime, so using static_assert on it as suggested by the TODO comment is not feasible and produces the following error when done:
error: static assertion expression is not an integral constant expression
initially referenced in bitcoin/bitcoin#32024