[clang-doc][NFC] Use isa<> over dyn_cast#136445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) ChangesFull diff: https://github.com/llvm/llvm-project/pull/136445.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-doc/Serialize.cpp b/clang-tools-extra/clang-doc/Serialize.cpp index 1dcccf3c3c2ab..bc31621f4a92e 100644 --- a/clang-tools-extra/clang-doc/Serialize.cpp+++ b/clang-tools-extra/clang-doc/Serialize.cpp@@ -246,9 +246,9 @@ static TypeInfo getTypeInfoForType(const QualType &T, return TypeInfo(Reference(SymbolID(), T.getAsString(Policy))); InfoType IT; - if (dyn_cast<EnumDecl>(TD)) {+ if (isa<EnumDecl>(TD)) { IT = InfoType::IT_enum; - } else if (dyn_cast<RecordDecl>(TD)) {+ } else if (isa<RecordDecl>(TD)) { IT = InfoType::IT_record; } else { IT = InfoType::IT_default; |
petrhosek approved these changes Apr 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.