Skip to content

[test_models_transformer_hunyuan_video] help us test torch.compile() for impactful models#11431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base:main
Choose a base branch
from
Open

[test_models_transformer_hunyuan_video] help us test torch.compile() for impactful models #11431

wants to merge 2 commits into from
+66 −1

Conversation

tongyu0924
Copy link
Contributor

@tongyu0924tongyu0924 commented Apr 28, 2025•
edited by sayakpaul
Loading

What does this PR do?

Part of #11430

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

sayakpaul
sayakpaul reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@sayakpaulsayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I just ran the tests but ran into errors: https://pastebin.com/A6c4gnwd.

@a-r-r-o-w possible to take a look when you have a moment?

tests/models/transformers/test_models_transformer_hunyuan_video.py
Comment on lines +93 to +95
deftest_gradient_checkpointing_is_applied(self):
expected_set= {"HunyuanVideoTransformer3DModel"}
super().test_gradient_checkpointing_is_applied(expected_set=expected_set)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done in a separate PR.

@a-r-r-o-w
Copy link
Member

Yeah, our Hunyuan implementation is not compatible with torch.compile back from when we integrated it. I'll open a PR rewriting the attention mask implementation

@a-r-r-o-wa-r-r-o-w self-requested a review April 28, 2025 13:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@tongyu0924@a-r-r-o-w@sayakpaul
close