Skip to content

[#143] Set the tag of the docker images to use#146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DavideD
Copy link
Member

Otherwise we rely on whatever version TestContainer uses as default
and it's not always the latest or could change between updates.

I decided to use the family version where available but we might
want to change this in the future and use the exact version to be
extra safe.

 Otherwise we rely on whatever version TestContainer uses as default and it's not always the latest or could change between updates. I decided to use the family version where available but we might want to change this in the future and use the exact version to be extra safe.
@DavideDDavideD requested a review from aguibertMay 20, 2020 14:20
@aguibert
Copy link
Contributor

Historically Testcontainers never changes the default label for exactly this reason -- updating could break users. But I still think it's a good idea to explicitly specify the version so that our docker (testcontainers) and podman devs are always using the same DBs

@DavideD
Copy link
MemberAuthor

I really don't understand the way they choose defaults in TestContainers. If they never update the tag why not always use the latest and clarify it in the javadoc?

Anyway, @aguibert did you also build the PR? GitHub seems to have some problem and cannot test it with the actions

@gavinking
Copy link
Member

GitHub seems to have some problem and cannot test it with the actions

The CI is busted since the change to the DB2 database name.

@DavideD
Copy link
MemberAuthor

Thanks, I will check

@DavideD
Copy link
MemberAuthor

Something was wrong with GitHub. It's working now.

@DavideD
Copy link
MemberAuthor

Merged #146

@DavideDDavideD closed this May 20, 2020
@DavideDDavideD linked an issue May 20, 2020 that may be closed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@DavideD@aguibert@gavinking
close