Wait for upto 8s for IDP sign in to finish, after popup is closed.#7140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4efa91a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
renkelvin approved these changes Mar 20, 2023
renkelvin left a comment
renkelvin left a comment There was a problem hiding this comment.
You may want to change the title of this PR to 8s.
Size Report 1Affected ProductsNo changes between base commit (ecb4454) and merge commit (b9ccd3e).Test Logs |
prameshj changed the title Size Analysis Report 1Affected ProductsNo changes between base commit (ecb4454) and merge commit (b9ccd3e).Test Logs |
prameshjforce-pushed the popup-timeout branch 4 times, most recently from 62d1ae2 to 279b746Compare
sam-gc approved these changes Mar 28, 2023
This is probably causing a real failure in the CI. will investigate and target the next release. |
prameshjforce-pushed the popup-timeout branch 3 times, most recently from d486d34 to 0241ba4Compareprameshjforce-pushed the popup-timeout branch 3 times, most recently from 37bf4ae to 59d2c86CompareIn some cases (Fiefox or mobile or if opener is an iframe), the popup is closed by the oauth helper code right after sign in has completed at the IDP. The IDP response still needs to be processed by the SDK + signInWithIdp API call needs to be invoked. This can take upto 7s, if there is a blocking function configured. Increase the poller timeout to 8s, so it does not reject the sign in with popup-closed-by-user error. increase timeout for the aborted sign in test.
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases (Fiefox or mobile or if opener is an iframe), the popup is closed by the oauth helper code right after sign in has completed at the IDP. The IDP response still needs to be processed by the SDK + signInWithIdp API call needs to be invoked. This can take upto 7s, if there is a blocking function configured. Increase the poller timeout to 8s, so it does not reject the sign in with popup-closed-by-user error.
Fixes - #7049, #7093
@sam-gc@renkelvin