Add CJS browser entry points for all packages#6981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d2bc9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
hsubox76 requested review from avolkovi, sam-gc, yuchenshi, lisajian, zwu52, maneesht, tonyjhuang, jsdt, jmwski and dwyfrequency as code owners
Merged
This was referenced Feb 2, 2023
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest in JSDOM mode expects browser-specific CJS packages to exist. Added CJS browser builds in packages where we don't have them and added
exports.browserpaths to point to them. (Note: packages that do not have separate Node and browser bundles do not useexports.nodeandexports.browserfields - a top levelrequirefield points at the CJS bundle and thedefaultfield points at the ESM bundle. Jest will recognize and use the top levelrequirefield.)See https://github.com/uuidjs/uuid/pull/642/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 for similar fix in
uuid.Note: Jest has experimental support for ESM and will probably make it officially supported at some point. We should test and make sure our setup and entry points work in that arrangement as well.