FIAM Programmatic triggers#3081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…dscape URLs to view model classes
…en already, Find a way to initialize a card message in the UI tests.
MeghaB reviewed May 24, 2019
MeghaB left a comment
MeghaB left a comment There was a problem hiding this comment.
API Looks good, made some logging/naming comments, and had some questions which (potentially) could just be iOS patterns, but curious :)
InAppMessaging/Example/App/InAppMessaging-Example-iOS/AutoDisplayFlowViewController.mShow resolvedHide resolved
InAppMessaging/Example/App/InAppMessaging-Example-iOS/AutoDisplayFlowViewController.m Outdated Show resolvedHide resolved
…e with overriding accessibility of card message params
Firebase/InAppMessaging/RenderingObjects/FIRInAppMessagingRenderingPrivate.hShow resolvedHide resolved
morganchen12 approved these changes May 28, 2019
charlotteliang approved these changes May 28, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds public method
triggerEvent:onFIRInAppMessagingto directly call onFIRIAMDisplayExecutorto check the message queue and display a contextual triggered message if applicable.Also adds unit tests and some UI functionality on the test app to trigger this flow during manual testing.
3ca83a6 also fixes an issue where overriding the access levels of
readonlyproperties inFIRInAppMessagingCardDisplayin a private header wasn't working as expected.