Remove Messaging FIRApp Class Category#1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merge the config setup to FIRMessaging rather than a FIRApp class category.
paulb777 reviewed Aug 9, 2018
| @@ -65,6 +65,10 @@ | |||
| /* End PBXAggregateTarget section */ | |||
| /* Begin PBXBuildFile section */ | |||
There was a problem hiding this comment.
Ahh, thanks! I was wondering if this was expected or not.
ryanwilson approved these changes Aug 9, 2018
| @@ -6631,12 +6631,12 @@ | |||
| BUNDLE_LOADER = "$(TEST_HOST)"; | |||
| CLANG_ANALYZER_NONNULL = YES; | |||
| CLANG_WARN_DOCUMENTATION_COMMENTS = YES; | |||
| DEBUG_INFORMATION_FORMAT = dwarf; | |||
There was a problem hiding this comment.
Can you revert the project file and do those in a separate commit? They should be changed but no reason to be part of this PR :)
charlotteliang approved these changes Aug 13, 2018
Please remember to squash and merge unless you're merging a long-lived high-value branch (like a release branch). |
Ah yes, sorry about that. I'll make sure to do so in the future. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the config setup to FIRMessaging rather than a FIRApp class category.