[Vertex AI] Add EncodableProtoEnum protocol and fix encoding#13862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
paulb777 approved these changes Oct 9, 2024
ncooke3 approved these changes Oct 9, 2024
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a protocol
EncodableProtoEnumsimilar toDecodableProtoEnum(added in #13859) that provides a defaultEncodableimplementation for Swift structs representing Protobuf enums. Before the default encoding produced invalid JSON forHarmCategory(refactored as a struct in #13854), e.g.:This PR resolves the nested object with a
raw_valueissue and produces:The integration tests have been updated to make use of
SafetySetting(includingHarmCategory) to catch encoding issues.#no-changelog