Updated podspec for internal FirebaseCore header#13829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-oss-bot commented Oct 7, 2024
Generated by 🚫 Danger |
Looking promising now. I'm getting convinced in the longer term, we should make a clean FirebaseExtensions module with all the "Internal" APIs and implementations for other Firebase modules. |
Updating CocoaPods-11.4.0 to this PR fixed all relevant nightlies except release and prerelease - which need nightly tag updated also. zip is still running, but well past the nightly failure. |
ncooke3 approved these changes Oct 7, 2024
MojtabaHs pushed a commit to MojtabaHs/firebase-ios-sdk that referenced this pull request Oct 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#13824