Skip to content

Potentially Dangerous Function (unarchiveObjectWithFile) in Messaging Component #9816

Closed
@grzegorzleszek

Description

@grzegorzleszek

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 13.2.1
  • Firebase SDK version: 8.13.0
  • Installation method: Swift Package Manager
  • Firebase Component: Messaging
  • Target platform(s): iOS

[REQUIRED] Step 2: Describe the problem

Our security team scanned our code and dependencies for vulnerabilities and found Use of Potentially Dangerous Function (CWE-676). Is there a plan to migrate to new api?

Source: FIRIAMClearcutLogStorage.m:171, FIRIAMActivityLogger.m:155

Attack Vector: NSKeyedUnarchiver.unarchiveObjectWithFile:

Description: Use of an unsafe function that are either deprecated due to security concerns, such as not conforming to secure coding practices, can introduce a vulnerability.
Most, if not all, of these functions have been documented as unsafe and should not be used, as mentioned in the WWDC session 'Threat Modeling', and can be replaced with more recent API calls.

Steps to reproduce:

Go to linked files, please note use of unarchiveObjectWithFile:
FIRIAMClearcutLogStorage.m:171
FIRIAMActivityLogger.m:155

Relevant Code:

... = [NSKeyedUnarchiver unarchiveObjectWithFile:filePath]; 

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      close