Description
Per Paul B - this has already been noticed internally and is in progress, he mentioned I could open an issue for tracking and I'd like to do so
My original comment on the PR between firebase-ios-sdk 10.15.0 and 10.16.0 follows:
When I attempt to update react-native-firebase to firebase-ios-sdk 10.16.0, including this PR, I receive this:
❌ /Users/mike/work/invertase/react-native-firebase/tests/ios/build/Build/Products/Debug-iphonesimulator/FirebaseAppCheck/FirebaseAppCheck.framework/Headers/FIRAppCheck.h:19:1: use of '@import' when C++ modules are disabled, consider using -fmodules and -fcxx-modules
@import FirebaseAppCheckInterop;
^
I traced it to this PR when I noticed that header file changed in my pod cache between 10.15.0 and 10.16.0. Is this an expected outcome? (stated differently, is there something I need to change so this works, ideally that wouldn't be a breaking change for us since we're adopting a feature release here...)
It's coming from here:
https://github.com/invertase/react-native-firebase/blob/c9b695aa8fd75d5a1d070ecbb6bb9ac4e9ff062e/tests/ios/testing/AppDelegate.mm#L21
Which goes to here:
https://github.com/invertase/react-native-firebase/blob/c9b695aa8fd75d5a1d070ecbb6bb9ac4e9ff062e/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.h#L22
Which goes to here:
https://github.com/invertase/react-native-firebase/blob/c9b695aa8fd75d5a1d070ecbb6bb9ac4e9ff062e/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.h#L18
...and that file doesn't go through with our compiler settings 🤔
Is there anything that can be done here?
In issues past, I have attempted to provide build instructions for our test app over in react-native-firebase so reproductions are easy but I/we have observed you all may have difficulty since it requires a relatively up to date javascript / node environment etc etc and that's a time suck if you don't already have it running. Let me know if you want repro instructions or any other information though, happy to collaborate of course
Originally posted by @mikehardy in #11660 (comment)