Skip to content

Fix the logic to generate .pro file#664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2021
Merged

Fix the logic to generate .pro file #664

merged 4 commits into from
Sep 15, 2021

Conversation

cynthiajoan
Copy link
Contributor

@cynthiajoancynthiajoan commented Sep 15, 2021•
edited
Loading

To address issue #604

DellaBitta
DellaBitta requested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@DellaBittaDellaBitta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes should be under 8.5.0.

You should merge main into your branch first to see the 8.5.0 release notes header in your branch.

@cynthiajoan
Copy link
ContributorAuthor

Can you update the release notes please?

Updated

@cynthiajoancynthiajoan added the tests-requested: quick Trigger a quick set of integration tests. label Sep 15, 2021
@github-actionsgithub-actionsbot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Sep 15, 2021
@github-actions
Copy link

github-actionsbot commented Sep 15, 2021•
edited
Loading

❌  Integration test FAILED

Requested by @DellaBitta on commit 2008044
Last updated: Wed Sep 15 15:41 PDT 2021
View integration test log & download artifacts

FailuresConfigs
messaging[TEST] [ERROR] [Android] [All os] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actionsgithub-actionsbot added the tests: failed This PR's integration tests failed. label Sep 15, 2021
@firebase-workflow-triggerfirebase-workflow-triggerbot removed the tests: in-progress This PR's integration tests are in progress. label Sep 15, 2021
@DellaBittaDellaBitta merged commit 2008044 into mainSep 15, 2021
@DellaBittaDellaBitta deleted the feature/rc_rest_update branch September 15, 2021 20:22
@github-actionsgithub-actionsbot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Sep 15, 2021
@firebase-workflow-triggerfirebase-workflow-triggerbot removed the tests: in-progress This PR's integration tests are in progress. label Sep 15, 2021
@firebasefirebase locked and limited conversation to collaborators Oct 16, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yestests: failedThis PR's integration tests failed.
3 participants
@cynthiajoan@DellaBitta@a-maurice
close