Removing google play requirement.#361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Not sure if we still need the App callback but I left it in there for now. Let me know if that can be safely removed too. |
a-maurice previously approved these changes Apr 9, 2021
What do you mean by "App callback"? |
jonsimantov requested changes Apr 12, 2021
release_build_files/readme.md Outdated
| @@ -584,6 +584,8 @@ code. | |||
| - General: Fixed rare crashes at application exit when destructors were | |||
| being executed | |||
| ([#345](https://github.com/firebase/firebase-cpp-sdk/pull/345)). | |||
| - General: Removed checks for Google Play Services in C++ for Auth, Database, | |||
There was a problem hiding this comment.
Also, it should be spelled "Google Play services" (with a lower-case "s")
jonsimantov approved these changes Apr 12, 2021
I figured out what you meant - those are needed for the Unity SDK to initialize the various C++ modules, I believe, and should be kept in place for now. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firebase Android SDKs for Auth, Database, Storage, Functions do not require Google Play Services anymore.
https://firebase.google.com/docs/android/android-play-services
Removing checks for Google Play services for these products from the C++ SDK.
Tested by running integration tests on,
Addresses firebase/quickstart-unity#975