Remove use of method_whitelist when possible

[xmo-odoo]

Deprecated in favor of allowed_methods. Fall back to the old argument for older
versions of urllib3 which do not support the new one.

Uses conditional attribute check as recommended in
urllib3/urllib3#2057

Fixes#515

RELEASE NOTE: Fixed a bug that prevented the proper operation of the SDK when used with certain versions of the urllib3 package.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[xmo-odoo]

@googlebot I signed it!

[hiranya911]

Thanks for the PR @xmo-odoo. This looks great! I just made a couple of comments. We can merge this once those comments are addressed.

[xmo-odoo]

Thanks for the PR @xmo-odoo. This looks great! I just made a couple of comments. We can merge this once those comments are addressed.

Done and done, though now that I look at the code again I'm wondering: maybe I should remove the current _ANY_METHOD constant and rename method_filter to that? It would provide essentially the same information (that you want to retry on every HTTP method by default) without an essentially unnecessary extra constant. **_ANY_METHOD might read slightly odd, but not that much.

That is, end up with this:

ifhasattr(retry.Retry.DEFAULT, 'allowed_methods'): _ANY_METHOD= {'allowed_methods': None} else: _ANY_METHOD= {'method_whitelist': None} # Default retry configuration: Retries once on low-level connection and socket read errors.# Retries up to 4 times on HTTP 500 and 503 errors, with exponential backoff. Returns the# last response upon exhausting all retries.DEFAULT_RETRY_CONFIG=retry.Retry( connect=1, read=1, status=4, status_forcelist=[500, 503], raise_on_status=False, backoff_factor=0.5, **_ANY_METHOD)

[hiranya911]

Thanks @xmo-odoo. Your suggestion looks good to me. Feel free to make the change. But I'm happy with the current state of the PR too.

[xmo-odoo]

@hiranya911 I pushed the updated version.