- Notifications
You must be signed in to change notification settings - Fork 7.6k
add dfrobot lorawan esp32s3 board#11300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
remove duplicate macro definitions
👋 Hello qhddz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qhddz ptal
dfrobot_lorawan_esp32s3.build.mcu=esp32s3 | ||
dfrobot_lorawan_esp32s3.build.core=esp32 | ||
dfrobot_lorawan_esp32s3.build.variant=dfrobot_lorawan_esp32s3 | ||
dfrobot_lorawan_esp32s3.build.board=ESP32S3_DEV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting changing the default build.board name.
dfrobot_lorawan_esp32s3.build.board=ESP32S3_DEV | |
dfrobot_lorawan_esp32s3.build.board=DFROBOT_LORAWAN_ESP32S3 |
#define WB_IO1 1 | ||
#define WB_IO2 1 | ||
#define WB_SW1 34 | ||
#define WB_A0 36 | ||
#define WB_LED1 -1 | ||
#define WB_LED2 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL and check if that's correct??WB_IO1
and WB_IO2
are both 1. Also WB_LED1
is -1.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Description of Change
add dfrobot lorawan esp32s3 board
Tests scenarios
All example codes were verified on the DFRobot LoRaWAN ESP32-S3 board base on Arduino SDK v3.2.0, confirming functionality across different scenarios.
Related links
product link: https://www.dfrobot.com/product-2933.html