Fix NewSketch crash when directories.user is not set#2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We were calling directly a function that lookup for user definied settings. In case an user did not set explictly the directory it would return an empty string causing a panic. Instead we should have used a dedicated function `UserDir` that uses a fallback the default directories.user
3 tasks
alessio-perugini added topic: code 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #2862 +/- ## ========================================== - Coverage 67.90% 67.87% -0.03% ========================================== Files 238 238 Lines 22412 22412 ========================================== - Hits 15218 15212 -6 - Misses 6001 6005 +4 - Partials 1193 1195 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmaglie approved these changes Mar 12, 2025
alessio-perugini deleted the 2861-grpc-server-crashes-on-new-sketch-request branch 3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fix a nil pointer
What is the current behavior?
When the
directories.useris not set by the user, an empty string is returned instead of using the default value. This leads to a panicWhat is the new behavior?
Use the
UserDirfunction that correctly fallback to default dir in case of empty string.Does this PR introduce a breaking change, and is titled accordingly?
Other information