Skip to content

Added BoardIdentify gRPC call.#2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 13, 2025

Conversation

cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Adds the BoardIdentify gRPC call, this function performs the board identification based on the given "upload port properties".

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmagliecmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Dec 23, 2024
@cmagliecmaglie self-assigned this Dec 23, 2024
@codecovCodecov
Copy link

codecovbot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 67.27273% with 54 lines in your changes missing coverage. Please review.

Project coverage is 67.68%. Comparing base (82f37f2) to head (85cbc63).
Report is 7 commits behind head on master.

Files with missing linesPatch %Lines
commands/service_board_identify.go67.40%31 Missing and 13 partials ⚠️
commands/service_board_list.go66.66%6 Missing and 4 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #2794 +/- ## ========================================== + Coverage 67.61% 67.68% +0.06%  ========================================== Files 238 239 +1 Lines 22392 22396 +4 ========================================== + Hits 15141 15159 +18 + Misses 6062 6045 -17 - Partials 1189 1192 +3 
FlagCoverage Δ
unit67.68% <67.27%> (+0.06%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmagliecmaglieforce-pushed the board-identify-grpc branch from 1432af1 to 85cbc63CompareJanuary 7, 2025 11:32
@cmagliecmaglie merged commit ed88bd8 into arduino:masterJan 13, 2025
101 checks passed
@cmagliecmaglie deleted the board-identify-grpc branch January 13, 2025 14:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPCRelated to the gRPC interfacetype: enhancementProposed improvement
2 participants
@cmaglie@alessio-perugini
close