settings: add network.connection_timeout and network.cloud_api.skip_board_detection_calls#2770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #2770 +/- ## ========================================== + Coverage 67.52% 67.55% +0.02% ========================================== Files 237 237 Lines 22362 22373 +11 ========================================== + Hits 15101 15115 +14 + Misses 6068 6066 -2 + Partials 1193 1192 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-peruginiforce-pushed the 2769-skip-or-time-out-network-requests-during-board-list branch from 4b44476 to 665d54dComparealessio-peruginiforce-pushed the 2769-skip-or-time-out-network-requests-during-board-list branch from 665d54d to 2278bbcComparealessio-perugini added type: enhancement 
The latest Buf updates on your PR. Results from workflow Check Protocol Buffers / check (pull_request).
|
cmaglieforce-pushed the 2769-skip-or-time-out-network-requests-during-board-list branch from 2d4aee1 to 6df6b17Comparecmaglieforce-pushed the 2769-skip-or-time-out-network-requests-during-board-list branch from 6df6b17 to ab8c357Comparecmaglieforce-pushed the 2769-skip-or-time-out-network-requests-during-board-list branch from 6d1db1e to ff3735fComparecmaglie changed the title connection_timeoutnetwork.connection_timeout and network.cloud_api.skip_board_detection_calls
MatteoPologruto approved these changes Dec 18, 2024
cmaglie deleted the 2769-skip-or-time-out-network-requests-during-board-list branch 3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Introduces:
connection_timeoutsetting, which our HTTP client will use as a timeout durationcloud_api.skip_board_detection_callsboolean setting that (iftrue) will skip the API call required to identify the board (if no installed platforms match the board).What is the current behavior?
The current behavior uses the default timeout which is 0. It means that it will wait indefinitely.
What is the new behavior?
The new behavior will respect user settings for the connection timeout. The default will be the same, but in case the user provides the
network.connection_timeout: 5it means that the HTTP client will exit with an error if the connection is taking longer than 5 seconds.There is also a new configuration value to disable querying the Cloud API to identify a board.
Does this PR introduce a breaking change, and is titled accordingly?
Other information