In compile command try to release the package manager lock ASAP#2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #2741 +/- ## ========================================== - Coverage 67.62% 67.54% -0.08% ========================================== Files 237 237 Lines 22354 22362 +8 ========================================== - Hits 15116 15104 -12 - Misses 6048 6066 +18 - Partials 1190 1192 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
cmaglie added type: enhancement 
alessio-perugini approved these changes Nov 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This PR fixes a concurrency problem in
Compile. When a compile is run, the function will keep the Boards Manager locked for the duration of the compile. This prevents another compile from running in parallel.This is mostly theoretical since the Arduino IDE does not allow starting two compilations together. BTW, there is another scenario that could be impacted: when the Arduino IDE starts the language server, the language server is required to run a bootstrap compilation in the background, and this compilation may prevent the user from compiling for some seconds.
What is the current behavior?
The package manager is kept locked during the whole compilation.
What is the new behavior?
The package manager is released once all information for compiling is gathered. The compilation then may run without locking the package manager.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information