Fixed compiler-cache on Windows when there are non-ASCII characters in file path#2733
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
As reported in #2671, the compile cache is not reused on a Windows machine if a non-ASCII character is present in the path.
EDIT: This is due to a weird encoding used by GCC in writing the
.d
file. It seems the file is written the default encoding with ANSI "codepages". This patch leverages the MultiByteToWideChar API to properly decode the .d files.What is the current behavior?
Already compiled files are not reused on a Windows machine if a non-ASCII character is present in the path.
What is the new behavior?
Already compiled files are reused on a Windows machine if a non-ASCII character is present in the path.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix#2671