Improved package index merging logic#2713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cmaglie added type: enhancement cmaglie requested review from alessio-perugini, facchinm, umbynos and MatteoPologruto
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #2713 +/- ## ========================================== - Coverage 67.68% 67.66% -0.02% ========================================== Files 234 234 Lines 22226 22226 ========================================== - Hits 15043 15040 -3 - Misses 6001 6003 +2 - Partials 1182 1183 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini approved these changes Oct 1, 2024
facchinm approved these changes Oct 1, 2024
Xayton approved these changes Oct 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
In some sporadic cases, there may exist some stale
package_*_index.jsonfiles with an invalid or empty entry in the tools section. In particular, due to the way the package indexes are loaded, the tool resource metadata may be overwritten or deleted by an invalid index. This change should improve the resilience of the Arduino CLI in most of these cases.What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information