Skip to content

Improved memory usage on core/libraries install#2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cmaglie
Copy link
Member

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This PR should improve memory usage on .zip archive extraction (for example on core install).
This is obtained through the upgrade of the 'extract' library.

What is the current behavior?

$ /usr/bin/time -f "%P %M" ./arduino-cli core install esp32:esp32 --additional-urls https://espressif.github.io/arduino-esp32/package_esp32_index.json 105% 1520148 $ 

What is the new behavior?

$ /usr/bin/time -f "%P %M" ./arduino-cli core install esp32:esp32 --additional-urls https://espressif.github.io/arduino-esp32/package_esp32_index.json 107% 272356 $ 

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Upstream patch: codeclysm/extract#21
Should fix: #2175

This is obtained through the upgrade of the 'extract' library. Upstream patch: codeclysm/extract#21
@cmagliecmaglie self-assigned this May 26, 2023
@cmagliecmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 26, 2023
@codecov
Copy link

codecovbot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02⚠️

Comparison is base (ca79383) 62.83% compared to head (7ff855a) 62.82%.

Additional details and impacted files
@@ Coverage Diff @@## master #2187 +/- ## ========================================== - Coverage 62.83% 62.82% -0.02%  ========================================== Files 220 220 Lines 19477 19477 ========================================== - Hits 12239 12236 -3 - Misses 6150 6152 +2 - Partials 1088 1089 +1 
FlagCoverage Δ
unit62.82% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmagliecmaglie merged commit b0d8ff8 into arduino:masterMay 26, 2023
@cmagliecmaglie deleted the improved_memory_usage_on_install branch May 26, 2023 14:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: codeRelated to content of the project itselftype: enhancementProposed improvement
2 participants
@cmaglie@umbynos
close