Fix Compile gRPC call hangs when there is a lot of output#2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cmaglie added type: imperfection cmaglie changed the title Compile gRPC call closing when there is a lot of outputCompile gRPC call hangs when there is a lot of output
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@## master #2171 +/- ## ========================================== - Coverage 62.55% 62.53% -0.02% ========================================== Files 223 223 Lines 19460 19488 +28 ========================================== + Hits 12173 12187 +14 - Misses 6196 6210 +14 Partials 1091 1091
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini approved these changes May 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fix gRPC
Compilecall hangs when there is a lot of output.What is the current behavior?
The gRPC
Compilecall sometimes hangs forever if there is a lot of output. For details see #2169.What is the new behavior?
The gRPC
Compilecall always completes.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
The same fix has been applied to all gRPC calls with streaming in output, even if there is no evidence of problems with it.
Fix#2169