Use variadic templates unconditionally#1367
Merged
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #1366 and building on PR #1364, we can simplify the code by no longer switching based on definition of
HAS_VARIADIC_TEMPLATE
: only the positive case will be considered given the baseline of C++11.So this PR removed this file by file, testing each commit locally in CI and arrived at removing the definition. A reverse dependency check is now running as well.
Checklist
R CMD check
still passes all tests