Skip to content

Update icon.svg#272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Update icon.svg #272

merged 1 commit into from
Mar 23, 2025

Conversation

stumbo
Copy link
Member

As a first step in fixing the navbar to make it more responsive I updated icon.svg . The icon was not behaving correctly. While I haven't found good documentation on the exact requirements of an icon.svg file, the W3C mentioned using inline SVG files as icons.

I rewrote the SVG file as inline. In addition, I cropped some of the extra white space from around the image. The results are a positive first step:

Prior to updating the icon:
image

After updating the icon:
image

Both images are of my browser at roughly 1210 pixels wide.

You will notice the title has slide over closer to the icon. This is a side effect of the icon better understanding how to be responsive. Prior to the update it was claiming all the real estate from itself up to the title. That space is now available for the other navbar menu items as the screen shrinks.

Shrinking the screen down to 950 pixels gives the following:
image

At about 750 pixels it changes the layout to two rows:

image

There is still more work to be done, there is some clipping of navbar items, search being most noticeable, But it also has clipped the GitHub and Get Involved items prior to dropping to the two row presentation. I'll continue to exam better ways of handling these issues.

@stumbostumbo self-assigned this Mar 22, 2025
Copy link
Member

@masintermasinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much improved... good start

@stumbostumbo merged commit 62ae813 into mainMar 23, 2025
@stumbostumbo deleted the update_icon.svg branch March 23, 2025 03:58
@pamoroso
Copy link
Contributor

I confirm it works much better. But, when scrolling down the page, I don't see the project name "The Medley Interlisp Project" between the Medley logo and the other icons in the site header as in the screenshots by @stumbo. This happens with Firefox on both Linux and Android.

@stumbo
Copy link
MemberAuthor

@pamoroso Can you provide an example? We do not put the project name in the navbar on the home page, but it should be displayed on all other pages. I see that behavior in my browser (Zen aka Firefox on Windows).

@pamoroso
Copy link
Contributor

Never mind, I was visiting the home page. I do see the project name on other pages.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@stumbo@pamoroso@masinter
close