Improving Lottery Simulation

Question

I'm working on a project for an Intro to C/Python class and am looking to improve the efficiency of the program. The program is a lottery simulation where the user inputs the number of tickets they want to buy, then generates tickets, and finally outputs the total winnings and net gain (usually loss).

This is my code (in Python, as required):

def main(): numb_tickets = int(input("How many tickets would you like to buy?\n")) #Calculate Winnings winnings = 0 for i in range(numb_tickets): #For testing only, gives feedback progress of program print(i," ",winnings) #Creating winning ticket/your ticket, find number of matches win_tic = getRandomTicket(MAX_VALUE, TIX_SIZE) my_tic = getRandomTicket(MAX_VALUE, TIX_SIZE) numb_win = numMatches(win_tic, my_tic) #Add appropriate payout for number of matches if numb_win == 6: winnings += WIN_SIX elif numb_win == 5: winnings += WIN_FIVE elif numb_win == 4: winnings += WIN_FOUR elif numb_win == 3: winnings += WIN_THREE #Calculate cost of purchasing tickets cost_tics = numb_tickets * COST_TIC if winnings >= cost_tics: profit = winnings - cost_tics print("You won $",winnings,", for a net earnings of $",profit,".", sep="") elif winnings < cost_tics: loss = cost_tics - winnings print("You won $",winnings,", for a net loss of $",loss,".", sep="") main() 

Note: the getRandomTicket() and numMatches() functions were provided by the professor to generate a lottery ticket and check the number of matches it has, respectively.

My program works fine for smaller numbers of tickets, but when testing the required 1,000,000 tickets, takes a massive amount of time. It makes sense that the time increases rapidly as the range of the loop increases, but I don't know of a better way to loop this yet. Any input or suggestions are greatly appreciated.

Answer 1

Doing this in a loop means O(N) time, where N = # of tickets.

If tickets are independent of each other, you can break this into chunks and process them in parallel. But threading is an advanced topic that you aren't likely to deal with in an intro class.

Answer 2

It's more of a style preference, but instead of the paragraph with if and elif's, I would do

winnings += payouts_dictionary[numb_wins] 

where

payouts_dictionary = {6: WIN_SIX, 5: WIN_FIVE, 4: WIN_FOUR, 3: WIN_THREE, 2: 0, 1: 0, 0: 0} 

is defined as a constant before the loop.

Answer 3

If this is python 2, try using xrange instead of range in your for loop. This will allow the for loop to generate the next iteration value on demand rather than generating and storing them all in memory upon the initial call to range.

See http://docs.python.org/2/library/functions.html#xrange

Answer 4

A major optimization that you could do is to define a dictionary for WIN_SIX, WIN_FIVE etc. This will return the value to add in O(1) rather than going into nested if else every time. Other than that you could combine all your statements like winnings += numb_win_dict[numMatches(getRandomTicket(MAX_VALUE, TIX_SIZE), getRandomTicket(MAX_VALUE, TIX_SIZE))] but it will result in loss of readability of your code. Final code would be like this:

numb_win_dict = { 3: WIN_SIX, 4: WIN_FOUR, 5: WIN_FIVE, 6: WIN_SIX} def main(): numb_tickets = int(input("How many tickets would you like to buy?\n")) #Calculate Winnings winnings = 0 for i in range(numb_tickets): #For testing only, gives feedback progress of program print(i," ",winnings) #Add appropriate payout for number of matches winnings += numb_win_dict[numMatches(getRandomTicket(MAX_VALUE, TIX_SIZE), getRandomTicket(MAX_VALUE, TIX_SIZE))] #Calculate cost of purchasing tickets cost_tics = numb_tickets * COST_TIC if winnings >= cost_tics: profit = winnings - cost_tics print("You won $",winnings,", for a net earnings of $",profit,".", sep="") elif winnings < cost_tics: loss = cost_tics - winnings print("You won $",winnings,", for a net loss of $",loss,".", sep="") main()