diff options
| author | Marcus Tillmanns <marcus.tillmanns@qt.io> | 2025-04-25 07:51:59 +0200 |
|---|---|---|
| committer | Marcus Tillmanns <marcus.tillmanns@qt.io> | 2025-04-25 06:45:56 +0000 |
| commit | c2fff26f3cdf24b5be96413d314cf4e459d2a735 (patch) | |
| tree | c76596d3ce49a6d8389684df3103eb5f59ae8967 | |
| parent | c1603c2e750dc8512101271dce787f0743c98c0e (diff) | |
Docker: Dont create the device twice
wizard.device() should be called wizard.createDevice() Change-Id: I0cfd6a392cb66a07d0b2e1340b06e73be715104f Reviewed-by: hjk <hjk@qt.io>
| -rw-r--r-- | src/plugins/docker/dockerdevice.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/docker/dockerdevice.cpp b/src/plugins/docker/dockerdevice.cpp index 65ddb258bff..a2ee0fab67c 100644 --- a/src/plugins/docker/dockerdevice.cpp +++ b/src/plugins/docker/dockerdevice.cpp @@ -1332,9 +1332,9 @@ DockerDeviceFactory::DockerDeviceFactory() DockerDeviceSetupWizard wizard; if (wizard.exec() != QDialog::Accepted) return IDevice::Ptr(); - m_existingDevices.writeLocked()->push_back( - std::static_pointer_cast<DockerDevice>(wizard.device())); - return wizard.device(); + auto device = std::static_pointer_cast<DockerDevice>(wizard.device()); + m_existingDevices.writeLocked()->push_back(device); + return std::static_pointer_cast<IDevice>(device); }); setConstructionFunction([this] { auto device = DockerDevice::create(); |
