diff options
| author | Thomas Hartmann <Thomas.Hartmann@qt.io> | 2025-04-10 18:36:34 +0200 |
|---|---|---|
| committer | Thomas Hartmann <thomas.hartmann@qt.io> | 2025-04-10 17:06:11 +0000 |
| commit | 9e995fe80155021ea92917063343f4dcb4b928d0 (patch) | |
| tree | 86da239f8ca33bdd73d3cc3beef2800706921cff | |
| parent | 4d93a8b663480582948b612516b7a471812e9b92 (diff) | |
QmlDesigner: Optimize condition
isBasedOn() handles equality. This already handles equality of types. Change-Id: If03e083ff6e3446341a37b8fd8fd8978bfc20666 Reviewed-by: Marco Bubke <marco.bubke@qt.io>
| -rw-r--r-- | src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp b/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp index 2a066343ca6..a62f507b943 100644 --- a/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp +++ b/src/plugins/qmldesigner/components/bindingeditor/bindingeditor.cpp @@ -177,10 +177,8 @@ bool isType(const TypeName &first, const TypeName &second, const Tuple &...types bool compareTypes(const NodeMetaInfo &sourceType, const NodeMetaInfo &targetType) { #ifdef QDS_USE_PROJECTSTORAGE - return targetType.isVariant() || sourceType.isVariant() || targetType == sourceType - || (targetType.isNumber() && sourceType.isNumber()) - || (targetType.isColor() && sourceType.isColor()) - || (targetType.isString() && sourceType.isString()); + return targetType.isVariant() || sourceType.isVariant() + || (targetType.isNumber() && sourceType.isNumber()) || sourceType.isBasedOn(targetType); #else const TypeName source = sourceType.simplifiedTypeName(); const TypeName target = targetType.simplifiedTypeName(); |
