Skip to content

Windows run#259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 13, 2020
Merged

Windows run #259

merged 10 commits into from
Apr 13, 2020

Conversation

argemiront
Copy link
Member

Add compatibility on Windows machines

argemirontand others added 8 commits April 12, 2020 17:12
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: argemiront <argemiront@gmail.com>
@argemirontargemiront requested a review from ShMcKApril 13, 2020 02:28
Copy link
Member

@ShMcKShMcK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested, and does not break anything on Mac.

We should also update the README where it states "Mac only"

Comment on lines +18 to +19
# cp -R ./web-app/build/ ./
cp -R ./web-app/build/ ./build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we wrap these in a os platform conditional in bash?

@ShMcK
Copy link
Member

closes #122

argemirontand others added 2 commits April 12, 2020 19:44
Signed-off-by: argemiront <argemiront@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcKShMcK merged commit 065df38 into masterApr 13, 2020
@ShMcKShMcK deleted the windows-run branch April 13, 2020 03:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@argemiront@ShMcK
close