summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
100 min.cid#1646742 Dereference after null checkHEADmasterCaolán McNamara1-1/+1
Change-Id: Id159ca8de614671db51fafb0e487d4d4f4548fbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
100 min.cid#1646741 COPY_INSTEAD_OF_MOVECaolán McNamara1-9/+5
Change-Id: I5405517c5661bdd4c94b6d09dde9775ba9ac0f2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184702 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
101 min.cid#1646746 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
Change-Id: I6e0ef99fd8bf4240e9b79bc0fca0257d80419509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184701 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
101 min.cid#1646747 Useless callCaolán McNamara1-1/+1
since: commit e06c771f610c5f5bac983df3ebf5e9700f74bf08 CommitDate: Fri Apr 25 07:31:34 2025 +0200 sw a11y: Use SwFrame directly in SwAccessibleMap::InvalidateEditableStates Change-Id: Ibd84c8095b8e30ac77ca1f7d522b41a29e01bb0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184700 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
101 min.cid#1646745 Uninitialized scalar fieldCaolán McNamara1-1/+0
unused Change-Id: If680564f64058a6e7ceb9aa08710210a6accb3ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184699 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 hoursRemove obsolete fw declarations from scaddins/Gabor Kelemen3-7/+0
found with bin/find-unneeded-includes --fwdecl Change-Id: I742740e45a78286aaa30dc16e787e370e4e16cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183899 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
3 hoursRemove obsolete fw declarations from scripting/Gabor Kelemen2-16/+0
found with bin/find-unneeded-includes --fwdecl Change-Id: Ie489c1dd7b682808d38dcb6e92ca49cbf391e08e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183900 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
3 hoursRemove obsolete fw declarations from reportdesign/Gabor Kelemen15-29/+0
found with bin/find-unneeded-includes --fwdecl Change-Id: Ib73a4a3f29d7707654ecb3bd84e9904f333c05ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183896 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
4 hourstdf#166319 sw interdependent redlines: fix undo of del on top of insMiklos Vajna3-2/+27
Load the document, it has an insertion and that has an additional deletion inside the deletion. Reject the insert, undo, reject it again: only the first half of the insertion gets rejected, instead of the entire insert. Reading the doc model xml dump, the problem is that the deletion is on top of the insert (so the large insert gets split to 1) insert 2) delete-on-insert and 3) insert), and the SwUndoRejectRedline only tracks the delete for 2), there is no SwRedlineData in the action for the previous insert part of 2). Fix the problem by using SwUndoAcceptRedline in DocumentRedlineManager::RejectRedlineRange(), which fixes the inconsistency of commit 52fa7aed48632166e064e6a227e034f0981c4205 (tdf#157662 SW: redline: accept/reject done for all parts, 2023-10-14), which used SwUndoRejectRedline + lcl_AcceptRedline() for the deletion inside the insert. This also means the custom depth is not needed for the created SwUndoAcceptRedline, again making the undo action and the actual action more consistent. Change-Id: I7f38854efa01b08ab4fc705d7bd976eaa585c3b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184695 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
4 hourssvx: prefix members of SdrCaptionObjMiklos Vajna2-25/+25
See tdf#94879 for motivation. Change-Id: Ic4cd593ee3605e2c6194ec52e25d27e0e8455b93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184693 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 hourstdf#166365: Crash in file picker, directory property (kf5/kf6)Julien Nabet1-1/+1
See bt from assertion here: https://bugs.documentfoundation.org/show_bug.cgi?id=166365#c1 Let's do the same as Gtk3KDE5FolderPicker::getDirectory() in vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx Change-Id: Iaea4e4b916c30cc14d3959725922c73e9d161625 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184691 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
10 hoursRelated: tdf#165448 move parent window to front after closing windowPatrick Luby1-4/+13
When a floating window such as the dropdown list in the font combobox is open when selecting any of the menu items inserted by macOS in the windows menu, the parent window will be hidden. So if there is a key window, force the key window back to the front. Previously, delaying closing of the window was used to avoid this bug, but that caused Skia/Metal to crash when the window was released before the delayed close occurred. This crash was found when rapidly dragging the border between two column headings side to side in a Calc document. Change-Id: I8511fe73e59c49f57d9179f5308e4b7a393809b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184690 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
10 hourstdf#153294 simplify for loop to std::find call in ImplHelper.cxxSimon Chenery1-6/+2
Change-Id: I3bf6b955942c0ef5bf6ab4398b1a2f3103a0a133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183488 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
10 hourstdf#147021 Use std::size() instead of SAL_N_ELEMENTS()Ahmed Khaled1-6/+6
Change-Id: I327c2724b2212551c8f957b5b4c151e317094fa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183050 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
10 hoursFix comment "last 3 bites" to "last 3 bits" in op.cxxSimon Chenery1-2/+2
Change-Id: I3f99bcb542bf025a009b3299d36c660fb3b431a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184688 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
17 hoursqt: Make some QtFrame DnD methods non-virtualMichael Weghorn1-4/+4
Change-Id: Ia38c86a15be846c844688e685329f4a32f4a0dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184679 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
20 hourstdf#166258 Refactor throttling of Skia/Metal flushesPatrick Luby3-6/+41
Throttling of Skia/Metal flushes is needed for tdf#163945 but the throttling logic was being applied to too frequently. So throttle based on the time interval of the last Skia/Metal flush and if the flush is too soon after the last flush (i.e. 1/200th of a second), schedule the flush in the Skia timer. Change-Id: Ib4e526ec26ec8b8d36bf3a9776bfe49d153d759f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184681 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
24 hoursDrop some copypaste errorsMike Kaganski1-4/+0
Also, aHighlightChangedTimer was already stopped above. Introduced in commit f89b9d8b8064a2f323f5b3362f88cb873bad8fcc (Resolves: tdf#100248 vcl menu scroll timer still active post dispose, 2016-06-09). Change-Id: I6969163f723b2a381fd5d595264bd6ed4012342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184680 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
27 hoursRemove obsolete fw declarations from package/Gabor Kelemen8-18/+1
found with bin/find-unneeded-includes --fwdecl Change-Id: I00bb2b3216bbd171bed6b71565876e6f60ccc083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183895 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
28 hoursRemove obsolete fw declarations from sc/Gabor Kelemen96-222/+7
found with bin/find-unneeded-includes --fwdecl Change-Id: I04083a33ce1e7d85980da91f72c2dd85777b594d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183897 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
28 hoursRemove obsolete fw declarations from sal/Gabor Kelemen1-5/+0
found with bin/find-unneeded-includes --fwdecl Change-Id: If0ab8906d469f70e3805efd98cf1da8589d55012 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183898 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
30 hourstdf#130857 qt weld: Make disabling tree view sorting workMichael Weghorn1-1/+4
Set the QSortFilterProxyModel's sort column to -1 to disable sorting. Quoting from the QSortFilterProxyModel::sortColumn doc [1]: > Returns the column currently used for sorting > > This returns the most recently used sort column. The default value is -1, > which means that this proxy model does not sort. > > See also sort(). It not working triggered a crash in SwGlossaryDlg::Init in a WIP branch for supporting the "Tools" -> "AutoText" dialog in Writer, because the QModelIndex set in the QtInstanceTreeIter returned as out param when inserting the item did not match the one in the sorted model when used later, and the `pData` in GroupUserData* pData = weld::fromId<GroupUserData*>(m_xCategoryBox->get_id(*xSearch)); if (!pData->bReadonly) would be null. (Whether that needs additional work to make sure that a valid iterator is still returned for the case where sorting is enabled may still be a valid question to be asked separately, in particular if any similar issue shows again in the future.) [1] https://doc.qt.io/qt-6/qsortfilterproxymodel.html#sortColumn Change-Id: Ibcb8e4318ecc85494141f75644955d26278dec9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184678 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
30 hourstdf#130857 qt weld: Implement QtInstanceTreeView::iter_*Michael Weghorn1-12/+26
Implement methods to get previous/next sibling, parent or first child. Change-Id: Icc32b980b595f23d727f0563afdad9e42a05d2b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184677 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
30 hourstdf#130857 qt weld: Implement QtInstanceTreeView::get_iter_depthMichael Weghorn1-3/+11
The implementations in GtkInstanceTreeView::get_iter_depth and SalInstanceTreeView::get_iter_depth suggest that the iter depth for top-level items is 0 (not 1), so implement it likewise. Change-Id: I61d9700ddd47d2088823c6440d5a8c0d5194a1f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184676 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
30 hourstdf#130857 qt weld: Ensure tree view col count is same on all levelsMichael Weghorn1-0/+4
Other than GtkTreeModel, where the same columns are always used on all hierarchy levels, QAbstractItemModel allows that to differ on each level/for each parent. This was seen causing a crash in a WIP branch experimenting with adding support for the "Tools" -> "AutoText" dialog because const QModelIndex aIndex = modelIndex(nPos, 0, aParentIndex); QStandardItem* pItem = itemFromIndex(aIndex); if (pStr) pItem->setText(toQString(*pStr)); inside QtInstanceTreeView::insert would result in trying to retrieve the index/item for column 0 when there were actually no columns in the model for the non-top-level item. Make sure the amount of columns matches by inserting them when there are none yet. Change-Id: I3bca4eb2e036e682298db7a205279bfddf0e8805 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184675 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
30 hourstdf#130857 qt weld: Keep col index in QtInstanceTreeView::copy_iteratorMichael Weghorn1-1/+2
The model index retrieved via QtInstanceTreeView::modelIndex may have an adjusted column number if the toggle button feature is enabled. However, if copying an iterator, the copy should be equivalent to the source, so use the unmodified QModelIndex from the source instead. While the weld::TreeIter as used in LO doesn't have a concept of columns but references a row (and the column index is passed as an extra param to methods where needed), not modifying the column set in the QModelIndex can still be relevant as QtInstanceTreeIter::equal directly compares the model indices of the two iters, so the copy wouldn't be considered equal if the column index is different. Change-Id: I3050daf17e7453cc62b1071647527ce888fd8a82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184674 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
30 hourstdf#130857 qt weld: Support non-top-level TreeView itemsMichael Weghorn2-21/+16
Drop the assert on `pParent` being null in QtInstanceTreeView::insert and instead implement handling for parent items. In most of the cases, the corresponding QAbstractItemModel methods have an optional (defaulting to `QModelIndex()`) param to specify the parent. Pass that param instead of using the default. This builds on top of this previous commit whose commit messages has some more details: Change-Id: Id829ce3a1052f0d8915f0b03a0b0786e2f3586dd Author: Michael Weghorn <m.weghorn@posteo.de> Date: Sat Apr 26 17:00:01 2025 +0200 tdf#130857 qt weld: Move TreeView method logic to overload for iters Change-Id: Ibb1a119e3fc6f0fa878babbe526990df42d78336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184673 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
30 hourstdf#130857 qt weld: Move TreeView method logic to overload for itersMichael Weghorn2-214/+215
weld::TreeView has a lot of methods that have two overloads where one takes a row index and the other takes a weld::TreeIter. In order to have to implement the logic in only one place, QtInstanceTreeView so far implemented the logic in the overload taking the row index, and the overload taking the weld::TreeIter would forward to the overload taking the row index. This was fine so far. As long the hierarchical structure of "actual" trees wasn't supported and all instances of QtInstanceTreeView where therefore just tables where all tree view items are top level items (s.a. the assert on `pParent` being null in QtInstanceTreeView::insert). However, in order to support non-top-level items, i.e. items that are children of other items, the approach needs to change because the row-index based overload only handles top-level items while a weld::TreeIter can also represent non-toplevel items. In order to prepare for that, switch the approach to be the other way around: Move the logic from the overload taking a row index to the overload taking a weld::TreeIter and let the one taking a row index call the one taking a weld::TreeIter instead. Introduce new helper method QtInstanceTreeView::treeIter to retrieve a TreeIter for a given (top-level) row index and adjust/add other helper methods as needed now. While at it, already start passing the QModelIndex::parent() [1] as an additional param to some of the called methods (instead of using the default, which would indicate they are top-level items). While this doesn't make any difference yet (as long as all items are top-level items), it helps prepare for supporting non-top-level items in the future. No change of behavior in any of the already supported dialogs is intended by this change. [1] https://doc.qt.io/qt-6/qmodelindex.html#parent Change-Id: Id829ce3a1052f0d8915f0b03a0b0786e2f3586dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184672 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
30 hourstdf#130857 qt weld: Implement QtInstanceTreeView::{g,s}et_sort_orderMichael Weghorn1-3/+16
As for the sort column, sorting by a certain sort order sets that sort order to be used in the future as well. Quoting the QSortFilterProxyModel::sortOrder doc [1]: > Returns the order currently used for sorting > > This returns the most recently used sort order. The default value is Qt::AscendingOrder. > > See also sort(). This will be used e.g. in Writer's "Tools" -> "AutoText" dialog once support for its .ui file (sw/uiconfig/swriter/ui/autotext.ui) will be declared in QtInstanceBuilder::IsUIFileSupported. [1] https://doc.qt.io/qt-6/qsortfilterproxymodel.html#sortOrder Change-Id: I4e569fde909188a1712eff45652772c95105d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184671 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
30 hourstdf#130857 qt weld: Add SolarMutexGuardMichael Weghorn1-0/+4
Change-Id: I190e865e2ea24ccc29bb7cbe1197472c16e4d259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184670 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
30 hourstdf#130857 qt weld: Suppport separator menu itemsMichael Weghorn1-0/+4
Implement support for "GtkSeparatorMenuItem" objects in .ui files. This is used e.g. in Writer's "Tools" -> "AutoText" dialog (.ui file: sw/uiconfig/swriter/ui/autotext.ui) which isn't supported by Qt weld yet. Change-Id: I506ad2627a174b5a48c256c5c9bce11189a95497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184669 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
39 hourscrashtesting: .doc output of ooo74516-1.odt cannot be reloadedCaolán McNamara1-1/+1
allow a larger starmath parse depth to accept this document Change-Id: I2b912be98958efb351de4cdc9f916831e70cf42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
41 hourstdf#164970 themes code cleanup, remove unneccessary assignment statementsSahil Gautam1-3/+4
Change-Id: I1377794519e1b3781b48ed13d2f7f6887e8f9d56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184392 Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de> Tested-by: Jenkins
42 hoursno need to call Width/Height on every iteration of loopNoel Grandin9-31/+31
Change-Id: If4615e004ad78936cfbafcad66e78dd66051d32f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184664 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
43 hoursScriptForge (UI) review progress bar terminationJean-Pierre Ledure1-1/+2
Idem https://gerrit.libreoffice.org/c/core/+/184662 for the progress bar. Change-Id: Ife48d115d3e8acb81fe167a27542783f4ca25d25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184665 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
45 hoursScriptForge Don't watch close button of stored dialogsJean-Pierre Ledure3-40/+44
Dialogs can either be stored in a library or created from scratch. When run in non-modal mode, the closing of a stored dialog with the Close top-right cross is done by LO correctly. When the dialog is created from scratch, a coded XTopWindowListener should do the job. So far, the listener was activated for all dialogs. Additionally the Console is a stored dialog. When closed and relaunched, the processing will now handle the window Close and the built-in Close buttons identically, at least apparently. Change-Id: I29e0881989816fbf7e3e8bd12f59517bde4b3047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184662 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2 daystdf#148251 use std::swap in indexentrysupplier_default.cxxSimon Chenery1-3/+1
Change-Id: I49cf4433fd0171d6e95d0c8c8cf5ae2d40b62614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184416 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Devansh Varshney <varshney.devansh614@gmail.com>
2 daysApplyAutoFilter: pass ScViewData by refXisco Fauli2-13/+13
Change-Id: Ie65b3347fcfad7ba3be2af48dc73e06c027231dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184659 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2 daysScShareDocumentDlg: pass ScViewData by refXisco Fauli3-7/+4
Change-Id: I6308802006c957a693db88746692a8dc63e53026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184658 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daysScCornerButton: pass ScViewData by refXisco Fauli2-8/+8
Change-Id: Id76186f6eb1d59f101273dc3d97fde1265c3e0ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184654 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daystdf#130857 Define widgets in "Select Paths" dialog in orderMichael Weghorn1-43/+43
Switch the order in which the widgets in the .ui file are defined so that the order matches the visual appearance (and "left-attach"/"top-attach" properties order), which makes sure that tab focus order with the Qt-based VCL plugins is correct as well when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where focus order is (by default) based on widget creation order. See commit 02692566ad9fc7c3484f8581ffa0004cd4e43987 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Oct 24 17:43:35 2024 +0200 tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order for more background. To trigger the dialog in Writer: "Tools" -> "AutoText", click "Path" button. Change-Id: I8502b32bba9cf7ea6bb420630ba9c80599decd7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184653 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
3 daystdf#130857 qt weld: Support "Select Paths" dialogMichael Weghorn1-0/+1
This means that native Qt widgets are used for that dialog now when using the qt5 or qt6 VCL plugin and starting LO with environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set. To trigger the dialog in Writer: "Tools" -> "AutoText", click "Path" button. Change-Id: I9bcf5253e80e2740151dc801bcd326df09529699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184652 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
3 dayscui: Resave selectpathdialog.ui with glade 3.40Michael Weghorn1-49/+46
To trigger the dialog in Writer: "Tools" -> "AutoText", click "Path" button. Change-Id: Ib86d3d6d827da27f2c0c88b94ea71cdd9f3ed4fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184651 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
3 daystdf#130857 qt weld: Don't multi-select tree items in single sel modeMichael Weghorn1-2/+6
Regardless of what selection mode is set for the tree view displaying the model, QItemSelectionModel::select adds to the selection and doesn't clear the previous one unless the QItemSelectionModel::Clear flag is passed. As a consequence, multiple tree view entries could be selected after QtInstanceTreeView::select was called. Prevent that by explicitly passing the QItemSelectionModel::Clear flag if the tree view is in single selection mode. Prior to this change, multiple entries were e.g. selected for the following scenario: * start Writer * "Tools" -> "AutoText", click "Categories" button * in the dialog, add various new categories by typing text in the "Category" edit and clicking the "New" button Behavior without this change in place for qt6 with SAL_VCL_QT_USE_WELDED_WIDGETS=1: All newly added categories would be selected at the same time. Behavior with this change in place: Only the last selected category is selected. This matches the behavior of other VCL plugins. Change-Id: I286b1e17b33d686553ae7c1533f07028b73bdfe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184650 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
3 daystdf#130857 Define widgets in sw "Edit Categories" dialog in orderMichael Weghorn1-62/+62
Switch the order in which the widgets in the .ui file are defined so that the order matches the visual appearance (and "left-attach"/"top-attach" properties order), which makes sure that tab focus order with the Qt-based VCL plugins is correct as well when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where focus order is (by default) based on widget creation order. See commit 02692566ad9fc7c3484f8581ffa0004cd4e43987 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Oct 24 17:43:35 2024 +0200 tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order for more background. To trigger the dialog in Writer: "Tools" -> "AutoText", click "Categories" button. Change-Id: I2ce55680902895171d5655b9e2c90275a492d3ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184649 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
3 daystdf#130857 qt weld: Support AutoText "Edit Categories" dialogMichael Weghorn1-0/+1
This means that native Qt widgets are used for that dialog now when using the qt5 or qt6 VCL plugin and starting LO with environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set. To trigger the dialog in Writer: "Tools" -> "AutoText", click "Categories" button. Change-Id: I4936591068ad1cac1a5ca3b1fef1405109258637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184648 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
3 dayssw: Resave editcategories.ui with glade 3.40Michael Weghorn1-65/+62
To trigger the dialog in Writer: "Tools" -> "AutoText", click "Categories" button. Change-Id: Ic718173aa1c8a468af963ac28381d2c0bcecfb9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184647 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
3 daysFix tar extraction issues when running as rootStephan Bergmann2-1/+2
Following up on 20b48ed9e311c529dcce46b31ed0d986ed7e3ed4 "Fix check-if-root for github.com/flathub-infra/vorarbeiter", the next issue those new github actions based flathub test builds run into is > tar: configure: Cannot change ownership to uid 1000, gid 1000: Invalid argument etc. from the various UnpackedTarball targets. The reason is that at least GNU tar 1.35 defaults to --same-owner when run as root. I hope the --no-same-owner countermeasure is available on all the GNU and BSD tar versions that we care about (it is at least supported by /usr/bin/tar bsdtar 3.5.3 on macOS Sequoia 15.4.1). Change-Id: Ie9a17856f9bca752817d914e6dd1b9cb2b5ea699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184645 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
3 daysScOutlineWindow: pass ScViewData by refXisco Fauli3-7/+7
Change-Id: Iea4da0879bfc281cdb430bec3285a1a5c2da4bba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184633 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
3 daysScQueryItem: always pass ScViewData from callerXisco Fauli5-17/+3
Change-Id: I02c061ecf4316907a020e1324c606ea53da7b8a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184630 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-28 11:15:57 +0000
close