Unit tests for Utils

Name: Unit tests for Utils · google/physical-web@19afdea · GitHub
Rating: 4.8 (9211 reviews)
google · Sep 23, 2016 · 19afdea · 19afdea
1 parent d51cbde
commit 19afdea
Show file tree
Hide file tree
Showing 4 changed files with 545 additions and 2 deletions.
diff --git a/android/PhysicalWeb/app/build.gradle b/android/PhysicalWeb/app/build.gradle
@@ -76,6 +76,8 @@ dependencies {
  compile 'com.android.support:appcompat-v7:24.0.0'
  compile 'com.youview:tinydnssd:1.2.7'
  compile 'org.nanohttpd:nanohttpd:2.3.0'
+ testCompile 'junit:junit:4.12'
+ testCompile 'org.mockito:mockito-core:1.10.19'
 
  checkstyleRules files('config/checkstyle/checkstyle.xml')
  findbugsRules files('config/findbugs/exclude-filter.xml')

diff --git a/android/PhysicalWeb/app/src/main/java/org/physical_web/physicalweb/Utils.java b/android/PhysicalWeb/app/src/main/java/org/physical_web/physicalweb/Utils.java
@@ -205,15 +205,15 @@ public static void hideAllMenuItems(Menu menu) {
 
 /**
  * Check if URL has been favorited.
- * @param siteUrl.
+ * @param siteUrl
  */
 publicstaticbooleanisFavorite(StringsiteUrl) {
 returnmFavoriteUrls.contains(siteUrl);
  }
 
 /**
  * Toggles favorite status.
- * @param siteUrl.
+ * @param siteUrl
  */
 publicstaticvoidtoggleFavorite(StringsiteUrl) {
 if (isFavorite(siteUrl)) {
@@ -506,6 +506,8 @@ public void connect(Context context) {
  */
 publicstaticStringformatEndpointForSharedPrefernces(StringpwsUrl, intpwsVersion,
 StringapiKey) {
+pwsUrl = pwsUrl == null ? "" : pwsUrl;
+apiKey = apiKey == null ? "" : apiKey;
 returnpwsUrl + SEPARATOR + pwsVersion + SEPARATOR + apiKey;
  }