fix(android): optimize table and list view updates (#12405)

* sync for thread safety * amend table fireEvent * revert to basic optimization * reduce cache size * validate first visible view * amend activity validation * allow marker to fire on partially visible rows * implement noresults event for ListView Fixes TIMOB-28294, TIMOB-28308

Author: build

android/modules/ui/src/java/ti/modules/titanium/ui/TableViewRowProxy.java

@@ -113,15 +113,13 @@ public TiUIView createView(Activity activity)
  }
 
 /**
- * Override fireEvent to inject row data into payload.
+ * Handle event data to generate payload with table data.
  *
  * @param eventName Name of fired event.
  * @param data Data payload of fired event.
- * @param bubbles Specify if event should bubble up to parent.
- * @return
+ * @return Object of payload.
  */
-@Override
-publicbooleanfireEvent(StringeventName, Objectdata, booleanbubbles)
+privateObjecthandleEvent(StringeventName, Objectdata)
  {
 // Inject row data into events.
 finalTableViewProxytableViewProxy = getTableViewProxy();
@@ -145,8 +143,29 @@ public boolean fireEvent(String eventName, Object data, boolean bubbles)
 data = payload;
  }
 
+returndata;
+ }
+
+/**
+ * Override fireEvent to inject row data into payload.
+ *
+ * @param eventName Name of fired event.
+ * @param data Data payload of fired event.
+ * @param bubbles Specify if event should bubble up to parent.
+ * @return
+ */
+@Override
+publicbooleanfireEvent(StringeventName, Objectdata, booleanbubbles)
+ {
+data = handleEvent(eventName, data);
 returnsuper.fireEvent(eventName, data, bubbles);
  }
+@Override
+publicbooleanfireSyncEvent(StringeventName, Objectdata, booleanbubbles)
+ {
+data = handleEvent(eventName, data);
+returnsuper.fireSyncEvent(eventName, data, bubbles);
+ }
 
 @Override
 publicStringgetApiName()

android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListItemProxy.java

@@ -118,35 +118,14 @@ public TiUIView createView(Activity activity)
 returnnull;
  }
 
-/**
- * Override fireEvent to inject ListItem data into payload.
- *
- * @param eventName Name of fired event.
- * @param data Data payload of fired event.
- * @param bubbles Specify if event should bubble up to parent.
- * @return
- */
-@Override
-publicbooleanfireEvent(StringeventName, Objectdata, booleanbubbles)
- {
-data = handleFireEvent(eventName, data);
-returnsuper.fireEvent(eventName, data, bubbles);
- }
-@Override
-publicbooleanfireSyncEvent(StringeventName, Objectdata, booleanbubbles)
- {
-data = handleFireEvent(eventName, data);
-returnsuper.fireSyncEvent(eventName, data, bubbles);
- }
-
 /**
  * Handle event payload manipulation.
  *
  * @param eventName Name of fired event.
  * @param data Data payload of fired event.
  * @return Object of event payload.
  */
-publicObjecthandleFireEvent(StringeventName, Objectdata)
+publicObjecthandleEvent(StringeventName, Objectdata)
  {
 // Inject row data into events.
 finalListViewProxylistViewProxy = getListViewProxy();
@@ -203,6 +182,27 @@ public Object handleFireEvent(String eventName, Object data)
 returndata;
  }
 
+/**
+ * Override fireEvent to inject ListItem data into payload.
+ *
+ * @param eventName Name of fired event.
+ * @param data Data payload of fired event.
+ * @param bubbles Specify if event should bubble up to parent.
+ * @return
+ */
+@Override
+publicbooleanfireEvent(StringeventName, Objectdata, booleanbubbles)
+ {
+data = handleEvent(eventName, data);
+returnsuper.fireEvent(eventName, data, bubbles);
+ }
+@Override
+publicbooleanfireSyncEvent(StringeventName, Objectdata, booleanbubbles)
+ {
+data = handleEvent(eventName, data);
+returnsuper.fireSyncEvent(eventName, data, bubbles);
+ }
+
 /**
  * Generate views from specified template.
  *

android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListSectionProxy.java

@@ -269,6 +269,7 @@ private ListItemProxy processItem(Object object)
 
 item.setParent(this);
 item.handleCreationDataItem(newKrollDict((HashMap) object));
+
 returnitem;
 
  } elseif (objectinstanceofListItemProxy) {
@@ -386,10 +387,11 @@ public void replaceItemsAt(int index, int count, Object dataItems,
 @Kroll.method
 publicvoidsetItems(ObjectdataItems, @Kroll.argument(optional = true) KrollDictanimation)
  {
+finalList<ListItemProxy> newItems = processItems(dataItems);
+
 removeAllItems();
 
-finalList<ListItemProxy> items = processItems(dataItems);
-this.items.addAll(items);
+this.items.addAll(newItems);
 
 // Notify ListView of new items.
 update();

android/modules/ui/src/java/ti/modules/titanium/ui/widget/listview/ListViewProxy.java

@@ -458,7 +458,7 @@ public void handleMarker(ListItemProxy item)
 continue;
  }
 finalbooleanisVisible =
-layoutManager.isViewPartiallyVisible(markedItemView, true, true);
+layoutManager.isViewPartiallyVisible(markedItemView, false, true);
 
 if (isVisible) {
 finalKrollDictdata = newKrollDict();