Skip to content

Commit 14cd341

Browse files
committed
refactor(ios): remove deprecated properties on ipad popover
This removes the height, width, leftNavButton and rightNavButton properties that have been deprecated since sdk 3.4.2 BREAKING CHANGE: Removes deprecated ipad popover properties: height, width, leftNavButton and rightNavButton
1 parent f63f721 commit 14cd341

File tree

1 file changed

+1
-56
lines changed

1 file changed

+1
-56
lines changed

iphone/Classes/TiUIiPadPopoverProxy.m

+1-56
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* Appcelerator Titanium Mobile
3-
* Copyright (c) 2010-2014 by Appcelerator, Inc. All Rights Reserved.
3+
* Copyright (c) 2010-2019 by Appcelerator, Inc. All Rights Reserved.
44
* Licensed under the terms of the Apache Public License
55
* Please see the LICENSE included with this distribution for details.
66
*/
@@ -129,61 +129,6 @@ - (void)setPassthroughViews:(id)args
129129
}
130130
}
131131

132-
- (void)setWidth:(id)value
133-
{
134-
ENSURE_SINGLE_ARG_OR_NIL(value, NSObject);
135-
DebugLog(@"[WARN] Setting width on the popover directly is deprecated. Change the width property of the contentView property instead");
136-
137-
if (IS_NULL_OR_NIL(value)) {
138-
poWidth = TiDimensionUndefined;
139-
} else {
140-
poWidth = TiDimensionFromObject(value);
141-
}
142-
[selfreplaceValue:value forKey:@"width"notification:NO];
143-
144-
if (popoverInitialized) {
145-
TiThreadPerformOnMainThread(^{
146-
[selfupdateContentSize];
147-
},
148-
NO);
149-
}
150-
}
151-
152-
- (void)setHeight:(id)value
153-
{
154-
ENSURE_SINGLE_ARG_OR_NIL(value, NSObject);
155-
DebugLog(@"[WARN] Setting height on the popover directly is deprecated. Change the height property of the contentView property instead");
156-
157-
if (IS_NULL_OR_NIL(value)) {
158-
poHeight = TiDimensionUndefined;
159-
} else {
160-
poHeight = TiDimensionFromObject(value);
161-
}
162-
[selfreplaceValue:value forKey:@"height"notification:NO];
163-
164-
if (popoverInitialized) {
165-
TiThreadPerformOnMainThread(^{
166-
[selfupdateContentSize];
167-
},
168-
NO);
169-
}
170-
}
171-
172-
- (void)setTitle:(id)item
173-
{
174-
DebugLog(@"[ERROR] Support for setting title on the popover directly is removed in 3.4.2");
175-
}
176-
177-
- (void)setRightNavButton:(id)args
178-
{
179-
DebugLog(@"[ERROR] Support for setting rightNavButton on the popover directly is removed in 3.4.2");
180-
}
181-
182-
- (void)setLeftNavButton:(id)args
183-
{
184-
DebugLog(@"[ERROR] Support for setting leftNavButton on the popover directly is removed in 3.4.2");
185-
}
186-
187132
#pragma mark Public Methods
188133

189134
- (void)show:(id)args

0 commit comments

Comments
 (0)
close