Skip to content

Commit dadb904

Browse files
authored
Merge pull request #2 from jfilla/master
fixed undefined property stdClass::$country, when called with multiple names without selected country
2 parents 6efbed5 + 2532f69 commit dadb904

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/GenderApi/Client/Result/MultipleNames.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public function parseResponse(\stdClass $response)
8787
if (isset($response->result) && is_array($response->result)) {
8888
foreach ($response->resultas$name) {
8989

90-
if ($response->country) {
90+
if (isset($response->country)) {
9191
$name->country = $response->country;
9292
}
9393

tests/GenderApi/Client/Result/MultipleNamesTest.php

+2
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,14 @@ public function testParseResponse()
2828
$this->assertEquals('bibi', $name->getName());
2929
$this->assertEquals(6715, $name->getSamples());
3030
$this->assertEquals(62, $name->getAccuracy());
31+
$this->assertEquals(null, $name->getCountry());
3132
}
3233

3334
if ($key == 1) {
3435
$this->assertEquals('jenniffer', $name->getName());
3536
$this->assertEquals(793, $name->getSamples());
3637
$this->assertEquals(99, $name->getAccuracy());
38+
$this->assertEquals(null, $name->getCountry());
3739
}
3840

3941
$this->assertEquals('female', $name->getGender());

0 commit comments

Comments
 (0)
close