Skip to content

Commit 114a033

Browse files
ayushr2gvisor-bot
authored andcommitted
Only allow host openat(2) syscalls with O_NOFOLLOW with directfs.
Updates the directfs seccomp filters to ensure that all openat(2) host syscalls have O_NOFOLLOW bit set. This would ensure that we don't follow a symlink in the host filesystem by mistake. The gofer client currently always uses O_NOFOLLOW. But this will help prevent any malicious usage of openat(2) if the sandbox is compromised somehow. The container filesystem is well-isolated from the host filesystems using pivot_root(2). So following a host symlink from sandbox context should still not escape the container. But this provides an additional layer of security. PiperOrigin-RevId: 523839219
1 parent f515471 commit 114a033

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

runsc/boot/filter/config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ func hostFilesystemFilters() seccomp.SyscallRules {
416416
{
417417
validFDCheck,
418418
seccomp.MatchAny{},
419-
seccomp.MatchAny{},
419+
seccomp.MaskedEqual(unix.O_NOFOLLOW, unix.O_NOFOLLOW),
420420
seccomp.MatchAny{},
421421
},
422422
},

0 commit comments

Comments
 (0)
close