Skip to content

Commit ff2d932

Browse files
committed
Address PR feedback
1 parent a20a324 commit ff2d932

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

.changeset/empty-doors-brush.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/database': patch
3+
---
4+
5+
Use new wire protocol parameters for startAfter, endBefore.

scripts/emulator-testing/emulators/database-emulator.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,18 @@ import { Emulator } from './emulator';
2121

2222
importrulesJSONfrom'../../../config/database.rules.json';
2323

24+
constDATABASE_EMULATOR_VERSION='4.11.0';
25+
2426
exportclassDatabaseEmulatorextendsEmulator{
2527
namespace: string;
2628

2729
constructor(port=8088,namespace='test-emulator'){
2830
super(
29-
'firebase-database-emulator-v4.11.0.jar',
31+
`firebase-database-emulator-v${DATABASE_EMULATOR_VERSION}.jar`,
3032
// Use locked version of emulator for test to be deterministic.
3133
// The latest version can be found from database emulator doc:
3234
// https://firebase.google.com/docs/database/security/test-rules-emulator
33-
'https://storage.googleapis.com/firebase-preview-drop/emulator/firebase-database-emulator-v4.11.0.jar',
35+
`https://storage.googleapis.com/firebase-preview-drop/emulator/firebase-database-emulator-v${DATABASE_EMULATOR_VERSION}.jar`,
3436
port
3537
);
3638
this.namespace=namespace;

0 commit comments

Comments
 (0)
close