Migrate Storage implementation from Objective-C to Swift#9963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Size Report 1Affected ProductsTest Logs |
Coverage Report 1Affected Products
Test Logs |
paulb777force-pushed the storage-swift-phase2 branch 2 times, most recently from 62909cf to 837e81aComparepaulb777force-pushed the storage-swift-phase2 branch from 837e81a to 5cd2df1Comparepaulb777force-pushed the storage-swift-phase2 branch from 7788dab to 6724e45Comparepaulb777force-pushed the storage-swift-phase2 branch from 898d59d to aaa6e91Comparepaulb777force-pushed the storage-swift-phase2 branch 2 times, most recently from 0d7a4da to 6529005Comparepaulb777force-pushed the storage-swift-phase2 branch from 6529005 to 4ffaa2bComparepaulb777 commented Sep 16, 2022
ncooke3 approved these changes Sep 21, 2022
paulb777force-pushed the storage-swift-phase2 branch from 7d06691 to 3d51280Comparencooke3 reviewed Sep 22, 2022
| open func listAll(completion: @escaping ((_: StorageListResult?, _: Error?) -> Void)) { | ||
| impl.listAll { listResult, error in | ||
| if error != nil { | ||
| open func listAll(completion: @escaping ((_: StorageListResult?, _: NSError?) -> Void)) { |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storage-swift-phase2is a long-lived branch for migrating the Storage implementation from Objective-C to Swift.Almost all of the changes are a straight port from Objective C to Swift. One exception is the Authorizer code implements a new GTMSessionFetcher protocol to avoid complexity around using
NSInvocationfrom Swift required with the old protocol.Key commits: