Skip to content

Fix Analytics SwiftPM platform availability.#9032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

ryanwilson
Copy link
Member

For some reason this still works in a project, but Xcode gets confused
and doesn't autocomplete the module appropriately. This should fix it
for tvOS and macOS.

Also cleaned up a few references to Analytics only being available on
iOS.

For some reason this still works in a project, but Xcode gets confused and doesn't autocomplete the module appropriately. This should fix it for tvOS and macOS. Also cleaned up a few references to Analytics only being available on iOS.
Copy link
Member

@paulb777paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect Xcode and SPM don't communicate properly about xcframeworks.

thanks for investigating! Just a few comment nits and LGTM.

@ryanwilson
Copy link
MemberAuthor

Merging now, the last commit just had a word added to the CHANGELOG.

@ryanwilsonryanwilson merged commit 59cb44b into masterNov 30, 2021
@ryanwilsonryanwilson deleted the rw-analytics-swiftpm branch November 30, 2021 16:05
@firebasefirebase locked and limited conversation to collaborators Dec 31, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
@ryanwilson@paulb777@google-oss-bot
close