Skip to content

Fall back to reCAPTCHA verification in phone auth if push notification is not received#8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2021
Merged

Fall back to reCAPTCHA verification in phone auth if push notification is not received #8653

merged 4 commits into from
Sep 15, 2021

Conversation

rosalyntan
Copy link
Member

@rosalyntanrosalyntan commented Sep 13, 2021•
edited
Loading

For phone auth app verification, if the push notification is not received before the timeout, fall back to reCAPTCHA for app verification.

[Google-internal bug: b/198507858]

@rosalyntan
Fall back to reCAPTCHA verification if the APNs notification for veri…
0ae194f
…fying the application is not received before the timeout.
@google-oss-bot
Copy link

google-oss-bot commented Sep 13, 2021•
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseAuth-iOS-FirebaseAuth.framework

    SDK overall coverage changed from ? (4046281) to 68.75% (21c989f) by ?.

    Click to show coverage changes in 106 files.
    FilenameBase (4046281)Head (21c989f)Diff
    FIRActionCodeSettings.m?100.00%?
    FIRAdditionalUserInfo.m?92.50%?
    FIRAuth.m?81.48%?
    FIRAuthAPNSToken.m?100.00%?
    FIRAuthAPNSTokenManager.m?50.52%?
    FIRAuthAppCredential.m?91.30%?
    FIRAuthAppCredentialManager.m?100.00%?
    FIRAuthBackend+MultiFactor.m?0.00%?
    FIRAuthBackend.m?86.46%?
    FIRAuthCredential.m?38.89%?
    FIRAuthDataResult.m?41.38%?
    FIRAuthDefaultUIDelegate.m?0.00%?
    FIRAuthDispatcher.m?100.00%?
    FIRAuthErrorUtils.m?74.50%?
    FIRAuthExceptionUtils.m?0.00%?
    FIRAuthGlobalWorkQueue.m?100.00%?
    FIRAuthKeychainServices.m?60.16%?
    FIRAuthNotificationManager.m?84.38%?
    FIRAuthProtoFinalizeMFAPhoneRequestInfo.m?0.00%?
    FIRAuthProtoFinalizeMFAPhoneResponseInfo.m?0.00%?
    FIRAuthProtoMFAEnrollment.m?0.00%?
    FIRAuthProtoStartMFAPhoneRequestInfo.m?0.00%?
    FIRAuthProtoStartMFAPhoneResponseInfo.m?0.00%?
    FIRAuthRequestConfiguration.m?100.00%?
    FIRAuthSerialTaskQueue.m?100.00%?
    FIRAuthSettings.m?53.85%?
    FIRAuthStoredUserManager.m?39.00%?
    FIRAuthTokenResult.m?80.43%?
    FIRAuthURLPresenter.m?48.72%?
    FIRAuthUserDefaults.m?100.00%?
    FIRAuthWebUtils.m?96.37%?
    FIRAuthWebView.m?0.00%?
    FIRAuthWebViewController.m?0.00%?
    FIRCreateAuthURIRequest.m?61.29%?
    FIRCreateAuthURIResponse.m?100.00%?
    FIRDeleteAccountRequest.m?100.00%?
    FIRDeleteAccountResponse.m?100.00%?
    FIREmailAuthProvider.m?54.55%?
    FIREmailLinkSignInRequest.m?91.30%?
    FIREmailLinkSignInResponse.m?100.00%?
    FIREmailPasswordAuthCredential.m?34.04%?
    FIRFacebookAuthCredential.m?38.46%?
    FIRFacebookAuthProvider.m?37.50%?
    FIRFinalizeMFAEnrollmentRequest.m?0.00%?
    FIRFinalizeMFAEnrollmentResponse.m?0.00%?
    FIRFinalizeMFASignInRequest.m?0.00%?
    FIRFinalizeMFASignInResponse.m?0.00%?
    FIRGameCenterAuthCredential.m?0.00%?
    FIRGameCenterAuthProvider.m?0.00%?
    FIRGetAccountInfoRequest.m?100.00%?
    FIRGetAccountInfoResponse.m?78.38%?
    FIRGetOOBConfirmationCodeRequest.m?87.40%?
    FIRGetOOBConfirmationCodeResponse.m?100.00%?
    FIRGetProjectConfigRequest.m?100.00%?
    FIRGetProjectConfigResponse.m?64.29%?
    FIRGitHubAuthCredential.m?38.46%?
    FIRGitHubAuthProvider.m?37.50%?
    FIRGoogleAuthCredential.m?40.00%?
    FIRGoogleAuthProvider.m?37.50%?
    FIRIdentityToolkitRequest.m?92.21%?
    FIRMultiFactor.m?10.79%?
    FIRMultiFactorInfo.m?0.00%?
    FIRMultiFactorResolver.m?0.00%?
    FIRMultiFactorSession.m?0.00%?
    FIROAuthCredential.m?51.35%?
    FIROAuthProvider.m?85.11%?
    FIRPhoneAuthCredential.m?31.37%?
    FIRPhoneAuthProvider.m?56.56%?
    FIRPhoneMultiFactorAssertion.m?0.00%?
    FIRPhoneMultiFactorGenerator.m?0.00%?
    FIRPhoneMultiFactorInfo.m?0.00%?
    FIRResetPasswordRequest.m?89.47%?
    FIRResetPasswordResponse.m?100.00%?
    FIRSecureTokenRequest.m?53.33%?
    FIRSecureTokenResponse.m?0.00%?
    FIRSecureTokenService.m?84.11%?
    FIRSendVerificationCodeRequest.m?93.10%?
    FIRSendVerificationCodeResponse.m?57.14%?
    FIRSetAccountInfoRequest.m?96.61%?
    FIRSetAccountInfoResponse.m?100.00%?
    FIRSignInWithGameCenterRequest.m?100.00%?
    FIRSignInWithGameCenterResponse.m?100.00%?
    FIRSignUpNewUserRequest.m?94.44%?
    FIRSignUpNewUserResponse.m?100.00%?
    FIRStartMFAEnrollmentRequest.m?0.00%?
    FIRStartMFAEnrollmentResponse.m?0.00%?
    FIRStartMFASignInRequest.m?0.00%?
    FIRStartMFASignInResponse.m?0.00%?
    FIRTwitterAuthCredential.m?40.00%?
    FIRTwitterAuthProvider.m?37.50%?
    FIRUser.m?68.88%?
    FIRUserInfoImpl.m?93.88%?
    FIRUserMetadata.m?86.36%?
    FIRVerifyAssertionRequest.m?90.79%?
    FIRVerifyAssertionResponse.m?87.84%?
    FIRVerifyClientRequest.m?100.00%?
    FIRVerifyClientResponse.m?100.00%?
    FIRVerifyCustomTokenRequest.m?89.47%?
    FIRVerifyCustomTokenResponse.m?100.00%?
    FIRVerifyPasswordRequest.m?94.12%?
    FIRVerifyPasswordResponse.m?65.38%?
    FIRVerifyPhoneNumberRequest.m?82.76%?
    FIRVerifyPhoneNumberResponse.m?81.25%?
    FIRWithdrawMFARequest.m?0.00%?
    FIRWithdrawMFAResponse.m?0.00%?
    NSData+FIRBase64.m?100.00%?

Test Logs

@google-oss-bot
Copy link

google-oss-bot commented Sep 13, 2021•
edited
Loading

Binary Size Report

Affected SDKs

  • FirebaseAuth

    TypeBase (4046281)Head (21c989f)Diff
    firebase-ios-sdk?1.03 MB? (?)

Test Logs

@rosalyntanrosalyntan changed the title Fall back to reCAPTCHA verification in phone auth if APNs notification is not receivedFall back to reCAPTCHA verification in phone auth if push notification is not receivedSep 14, 2021
@rosalyntanrosalyntan marked this pull request as ready for review September 14, 2021 00:31
maksymmalyhin
maksymmalyhin approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhinmaksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

yoyomyo
yoyomyo reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@yoyomyoyoyomyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this PR! I learned how delegates are passed. That said, there is nothing I could contribute as a reviewer 😂

@rosalyntanrosalyntan merged commit 90ccc59 into masterSep 15, 2021
@rosalyntanrosalyntan deleted the rosalyntan.recaptcha branch September 15, 2021 00:21
@firebasefirebase locked and limited conversation to collaborators Oct 15, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: authcla: yes
4 participants
@rosalyntan@google-oss-bot@yoyomyo@maksymmalyhin
close