Migrate transform: callsites and introduce breaking version of GDT (9.0)#7899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For this type of change, which CHANGELOGs should be modified? The FirebaseCore/CHANGELOG or the CHANGELOGs that correspond to specs that have been changed? |
paulb777 requested changes Apr 14, 2021
Coverage ReportAffected SDKsNo changes between base commit (35f97e4) and head commit (90fc05a). Test Logs
|
To fix the CI failure, https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseMLModelDownloader/Apps/Sample/Podfile should be updated to get FirebaseCoreDiagnostics from the local repo - similar syntax to https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseMLModelDownloader/Apps/Sample/Podfile#L8 |
paulb777 approved these changes Apr 15, 2021
ncooke3 commented Apr 19, 2021
| @@ -6,6 +6,7 @@ source 'https://github.com/firebase/SpecsStaging.git' | |||
| source 'https://cdn.cocoapods.org/' | |||
| pod 'FirebaseMLModelDownloader', :path => '../../../' | |||
| pod 'FirebaseCoreDiagnostics', :path => '../../../' | |||
cc @visumickey |
visumickey approved these changes Apr 19, 2021
Can address any additional feedback in a subsequent PR. |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• There is an upcoming breaking change in GDT (8.4 -> 9.0) where the
transform:API has been renamed totransformGDTEvent:to avoid collisions with one of Apple's private APIs.This PR prepares for this change by:
• Migrating callsites to the new API
• Updating specs to point to next major version of GDT (9.0)
This is planned to be a part of Firebase 8.
Fixes#7177